Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show icons with same tags on icon page #473

Open
vanillajonathan opened this issue Oct 29, 2020 · 8 comments · May be fixed by #1685
Open

Show icons with same tags on icon page #473

vanillajonathan opened this issue Oct 29, 2020 · 8 comments · May be fixed by #1685
Labels
docs Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed

Comments

@vanillajonathan
Copy link
Contributor

Example on the page: https://icons.getbootstrap.com/icons/arrow-right-square-fill/
Show a header called "More icons" or something with right arrow not filled, left arrow, etc.

Like Font Awesome does:
https://fontawesome.com/icons/database?style=solid
When you scroll down it says "More Computers Icons".

@mdo
Copy link
Member

mdo commented Oct 29, 2020

Would love that! I'd also love to do category pages and more to help lessen the page load on the homepage.

@mdo mdo added docs Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed labels Oct 29, 2020
@XhmikosR
Copy link
Member

XhmikosR commented Apr 4, 2023

This is fixed in 1.10.4. We went with q=brand. We can change the query param to something else since I agree, it's not very self-explanatory. Suggestions welcome.

@XhmikosR XhmikosR closed this as completed Apr 4, 2023
@vanillajonathan
Copy link
Contributor Author

There is still no list of categories which would be helpful when browsing.

@XhmikosR
Copy link
Member

XhmikosR commented Apr 4, 2023

It's not quite the same thing, and we plan to try to add taxonomies in the next version. Feel free to make a new issue if there isn't one.

@vanillajonathan
Copy link
Contributor Author

Sounds good.

The Bootstrap Icons page still doesn't show related icons on the page for the icon though, only when searching.
The original post describes it in another way where each icon page also shows related icons.

@XhmikosR XhmikosR reopened this Apr 4, 2023
@XhmikosR
Copy link
Member

XhmikosR commented Apr 4, 2023

@vanillajonathan vanillajonathan linked a pull request Apr 5, 2023 that will close this issue
@vanillajonathan
Copy link
Contributor Author

Thanks, I filed a PR by looking at the two code snippets you provided.

@XhmikosR
Copy link
Member

XhmikosR commented Apr 5, 2023

It's not enough, though 😛

You need to take care of the layout too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants