Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token is never refreshed #35

Open
umonaca opened this issue Oct 20, 2021 · 2 comments
Open

Token is never refreshed #35

umonaca opened this issue Oct 20, 2021 · 2 comments

Comments

@umonaca
Copy link

umonaca commented Oct 20, 2021

if self.is_connect() is False:

But is_connect() never check if the token is expired.

Besides, this bug needs more than a one-line fix. You have another hidden problem in your code:

__request() => __refresh_access_token_if_need() => post() => __request() => __refresh_access_token_if_need()

Currently the loop breaks because of is_connect() == True. However, you should be aware that once you fix the bug mentioned above, you must also check whether path.startswith(TO_C_REFRESH_TOKEN_API).

@aambroze
Copy link

Any update on that ?

@awm1
Copy link

awm1 commented Feb 3, 2023

Any update on that ?

No, there are several pull requests that would solve this issue, however, any of developers won't even reject them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants