Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bit flawed IMO #6

Open
eckstein opened this issue Jan 14, 2024 · 0 comments
Open

A bit flawed IMO #6

eckstein opened this issue Jan 14, 2024 · 0 comments

Comments

@eckstein
Copy link

This project/example is a great resource, but there are some things that are just a bit confusing to me. I understand for the sake of code weight, just using a table for simple one-column layouts without divs, but this presents issues with consistency across rows of content and I think the extra couple lines of code to do ghost tables here would be much less confusing and more maintainable.
Secondly, if you need to have a section have a different background color, it doesn't work with this weird padding convention where you have to manually set a padding on every row of the layout to line up the edges. Adding a background color to a section with this method would mean a nested ghost table and div inside another just for a bg color, which, while technically works, is not ideal when the rest of the rows don't have this. It would be much better to wrap each row by default with its own wrapper div/ghost table with its own padding so background color can be controlled within the padding of each section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant