Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<div><table class="column"> vs <table class="column" #1

Open
bago opened this issue Sep 21, 2015 · 0 comments
Open

<div><table class="column"> vs <table class="column" #1

bago opened this issue Sep 21, 2015 · 0 comments

Comments

@bago
Copy link

bago commented Sep 21, 2015

Is there a reason you use a wrapping div for the 2-columns while you direclty put the "content" class in the table for the 3-columns?

Also, you have styles declaring ".column" as display: inline-block but you don't put it back to "display: table" or "display: block" on media query:

I'd expect something like this in the @media query:

    .column {
        display: block !important;
    }
    table.column {
        display: table !important;
    }

Otherwise a small content would not push its ".content" to 100%.

Another option would be to use "width" instead of "max-width" in the @media rules, but maybe there is a reason to not use it... any hint?

Thank you for sharing this template!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant