@tus/server: allow onUploadFinish hook to override response data

packages/server/src/handlers/PostHandler.ts

@@ -203,10 +203,15 @@ export class PostHandler extends BaseHandler {
       }
     }
 
+    //Only append Location header if its valid for the final http status (201 or 3xx)
+    if (responseData.status === 201 || responseData.status.toString().at(0) === '3') {
+      responseData.headers['Location'] = url
+    }
+
     const writtenRes = this.write(
       res,
       responseData.status,
-      Object.assign({Location: url}, responseData.headers),
+      responseData.headers,
       responseData.body
     )
 

packages/server/test/PostHandler.test.ts

@@ -347,6 +347,24 @@ describe('PostHandler', () => {
         assert.equal(upload.offset, 0)
         assert.equal(upload.size, 0)
       })
+
+      it('does not set Location header if onUploadFinish hook returned a not eligible status code', async function () {
+        const store = sinon.createStubInstance(DataStore)
+        const handler = new PostHandler(store, {
+          path: '/test/output',
+          locker: new MemoryLocker(),
+          onUploadFinish: async (req, res) => ({res, status_code: 200}),
+        })
+
+        req.headers = {
+          'upload-length': '0',
+          host: 'localhost:3000',
+        }
+        store.create.resolvesArg(0)
+
+        await handler.send(req, res, context)
+        assert.equal('location' in res._getHeaders(), false)
+      })
     })
   })
 })