Code does not trap for an "empty" $modname

[mhughes2k]

Line 2905 in turnitin/lib.php has a condition where the $modname can end up being "".

This line

moodle-plagiarism_turnitin/lib.php

Line 1652 in 8cf0d4f

$moduleclass = "turnitin_".$modname;

does not check that $modname is not empty and on that assumption tries to instantiate a class called "turnitin_".

This should have a check that the class is a valid one.

This seems to be caused by

moodle-plagiarism_turnitin/lib.php

Line 2908 in 8cf0d4f

isset($formwrapper->get_current()->modulename) ? 'mod_'.$formwrapper->get_current()->modulename : '');

which checks for a mod name being set and if not found sets $modname to '', which will result in never finding a valid class in the line above.

So either you need to validate the instantiation of the class to a valid class name or there is something incorrect that L2908 is ending up with an empty modname.

[jack-tii]

Thanks for flagging this up. I'll make sure this is checked for in our next release.