Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check JS Foundations for tests requiring impurity #680

Open
wvmitchell opened this issue Apr 20, 2023 · 0 comments
Open

Check JS Foundations for tests requiring impurity #680

wvmitchell opened this issue Apr 20, 2023 · 0 comments

Comments

@wvmitchell
Copy link
Collaborator

Description

In seeing students solve the current (new) JS foundations, some of the tests cannot be passed without creating an impure function. None of the tests should require this.

Summary of Changes

  • Solve all the existing JS foundations, looking for spaces where the test cannot be solved without creating an impure function
  • Refactor/replace any tests that require the creation of an impure function

Note

  • Testing for the side effect of a function is an example of this. If you encounter a test where it is expected that something has changed as the result of running a function, but that function didn't return anything, it's a side effect, and needs to go away.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant