From 23e595d461407d447a42a4f04298636a5b428823 Mon Sep 17 00:00:00 2001 From: Heather Faerber Date: Wed, 30 Oct 2024 06:34:28 -1000 Subject: [PATCH 1/4] fix typo --- module3/projects/rancid_tomatillos/technical_requirements.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/module3/projects/rancid_tomatillos/technical_requirements.md b/module3/projects/rancid_tomatillos/technical_requirements.md index ced22e41..d576afd8 100644 --- a/module3/projects/rancid_tomatillos/technical_requirements.md +++ b/module3/projects/rancid_tomatillos/technical_requirements.md @@ -169,8 +169,8 @@ We've also given you some mock data to use for your testing. You can find those - As a user, when I load the application, I see a collection of movies. - Note: When testing a collection of elements, it's good practice to check that... - The number of elements we expect to be there are there (i.e. there are 4 movie posters) - - The first element contains all the information we'd epect (i.e. correct image and vote count) - - The last element contains all the information we'd epect (i.e. correct image and vote count) + - The first element contains all the information we'd expect (i.e. correct image and vote count) + - The last element contains all the information we'd expect (i.e. correct image and vote count) - As a user, when I click on a movie, I'm shown additional details about that movie. - Note: We want to check ALL details. Just checking Title is not enough. - As a user, when I upvote a movie, I see the movie's votes increase by one. From 8da5fa0769fd63467654dab2630a1c5e1af309f6 Mon Sep 17 00:00:00 2001 From: Heather Faerber Date: Wed, 30 Oct 2024 15:31:18 -1000 Subject: [PATCH 2/4] Move sad paths and bad routes to meeting expectations --- module3/projects/rancid_tomatillos/evaluation.md | 6 ++---- .../projects/rancid_tomatillos/technical_requirements.md | 4 ++-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/module3/projects/rancid_tomatillos/evaluation.md b/module3/projects/rancid_tomatillos/evaluation.md index e2221084..201240d1 100644 --- a/module3/projects/rancid_tomatillos/evaluation.md +++ b/module3/projects/rancid_tomatillos/evaluation.md @@ -78,11 +78,11 @@ We expect all teammates to: - Tests make specific assertions about the content DOM elements contain - Network requests are properly stubbed (intercepted) - Happy path async functionality is stubbed and tested + - Sad path functionality is stubbed and tested **Exceeds Expectations** can look like: - - Sad path async functionality is stubbed and tested - - Implements Cypress `alias` and `wait()` - Implements Cypress `fixture` + - Implements Cypress `alias` and `wait()` - Implements Cypress `command` @@ -94,7 +94,5 @@ We expect all teammates to: - Application uses Router to display appropriate components based on URL - The user has access to previous routes via the back/forward buttons - Code was refactored to remove unnecessary or old code artifacts - -**Exceeds Expectations** can look like: - A 404 page handles unknown routes. *You can check this by going to localhost:3000/nonsense* \ No newline at end of file diff --git a/module3/projects/rancid_tomatillos/technical_requirements.md b/module3/projects/rancid_tomatillos/technical_requirements.md index d576afd8..9dba8106 100644 --- a/module3/projects/rancid_tomatillos/technical_requirements.md +++ b/module3/projects/rancid_tomatillos/technical_requirements.md @@ -169,8 +169,8 @@ We've also given you some mock data to use for your testing. You can find those - As a user, when I load the application, I see a collection of movies. - Note: When testing a collection of elements, it's good practice to check that... - The number of elements we expect to be there are there (i.e. there are 4 movie posters) - - The first element contains all the information we'd expect (i.e. correct image and vote count) - - The last element contains all the information we'd expect (i.e. correct image and vote count) + - The first element contains all the specific data details we'd expect (correct image, vote count, etc) + - The last element contains all the specific data details we'd expect (correct image, vote count, etc) - As a user, when I click on a movie, I'm shown additional details about that movie. - Note: We want to check ALL details. Just checking Title is not enough. - As a user, when I upvote a movie, I see the movie's votes increase by one. From 94b822d1858619dcd9a8f94ab5dbfd3db8aa6d62 Mon Sep 17 00:00:00 2001 From: Heather Faerber Date: Wed, 30 Oct 2024 15:36:38 -1000 Subject: [PATCH 3/4] Add note for presentation in rubric --- module3/projects/rancid_tomatillos/evaluation.md | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/module3/projects/rancid_tomatillos/evaluation.md b/module3/projects/rancid_tomatillos/evaluation.md index 201240d1..b055bc49 100644 --- a/module3/projects/rancid_tomatillos/evaluation.md +++ b/module3/projects/rancid_tomatillos/evaluation.md @@ -31,8 +31,8 @@ Your presentation should cover the following points: ## Rubric