Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing deps - Socket #56

Open
c4710n opened this issue Oct 21, 2022 · 2 comments · May be fixed by #58
Open

Missing deps - Socket #56

c4710n opened this issue Oct 21, 2022 · 2 comments · May be fixed by #58

Comments

@c4710n
Copy link

c4710n commented Oct 21, 2022

I found the DNS server is using a module Socket, but the module is not provided in this project.

Is that the package - socket on Hex.pm? If it is, why didn't we add it to deps?

Maybe, I can help to do this.
@tungd
Copy link
Owner

tungd commented Nov 1, 2022

Hi @c4710n , which version are you using? We've dropped socket as a dependency on the latest version.

@c4710n
Copy link
Author

c4710n commented Nov 1, 2022

The latest version - 2.4.0

I found DNS.Server is still calling Socket:

glaszig added a commit to glaszig/elixir-dns that referenced this issue Mar 27, 2023
@glaszig
fix server
87ccd6d 
the elixir socket library was removed in 933c5c4 in favor
of erlang stdlib so gen_udp has to be used in the server as well
instead of Socket.

closes tungd#56
@glaszig glaszig linked a pull request Mar 27, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix server glaszig/elixir-dns
2 participants
@tungd @c4710n