New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin resets the authentication method #3

Open

luisdev opened this issue Oct 1, 2019 · 0 comments

luisdev commented Oct 1, 2019 •

edited

Loading

This issue raised by Olli Savolainen in the comments on https://moodle.org/plugins/local_usersynccsv:

"There is an undocumented behaviour of this plugin, it resets the authentication method and various other data.

 $user->lang = $CFG->lang;
 $user->mnethostid = $CFG->mnet_localhost_id;
 $user->auth = 'manual';
 $user->confirmed = 1;
 if (empty($user->city)) {
 $user->city = "none";
 }
 if (empty($user->country)) {
 $user->country = "no";
 }

So in many scenarios these should be commented out to avoid unintended consequences."

I agree that the plugin should not change the $user->auth to "manual" each time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment