Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve exception safety with smart pointers #52

Open
elfring opened this issue Mar 23, 2020 · 2 comments
Open

Improve exception safety with smart pointers #52

elfring opened this issue Mar 23, 2020 · 2 comments

Comments

@elfring
Copy link

elfring commented Mar 23, 2020

Would you like to wrap any pointer data members with the class template “std::unique_ptr”?
@NikolausDemmel
Copy link
Contributor

Please see my comment: #51 (comment)

In general, yes, that is great practice. For this project at this stage probably too intrusive with no real benefit considering development is not active, sorry.

@t-lou
Copy link

t-lou commented Jul 30, 2020

I don't mind trying to fix some and creating pull requests, would it be okay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NikolausDemmel @elfring @t-lou