Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grasp position detector: move robot specific parameters to robotpart attributes instead of arguments. #1248

Open
PetervDooren opened this issue Oct 4, 2022 · 0 comments
Open

grasp position detector: move robot specific parameters to robotpart attributes instead of arguments. #1248

PetervDooren opened this issue Oct 4, 2022 · 0 comments
Labels
Low Priority Not super important. But should be done at some point

Comments

@PetervDooren
Copy link
Contributor

PetervDooren commented Oct 4, 2022 •
edited by MatthijsBurgh
Loading

As discussed in https://github.com/tue-robotics/tue_robocup/pull/1239/files#r985110147 and https://github.com/tue-robotics/tue_robocup/pull/1239/files#r985110332, the grasp detector smach state has some magic numbers for the minimum joint position where detection is possible (i.e. fingers closed). However this value is robot specific. currently it is supplied as a default argument which can be changed by a user but this value should not change in between tries as it is tied to the robot. It would therefore make more sense to have it as an attribute of a robot part.
@PetervDooren PetervDooren added the Low Priority Not super important. But should be done at some point label Oct 4, 2022
@PetervDooren PetervDooren mentioned this issue Oct 4, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Low Priority Not super important. But should be done at some point
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PetervDooren