Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSN transmitting frequency ramp tables overlap #271

Open
valeriof7 opened this issue Dec 16, 2024 · 0 comments
Open

DSN transmitting frequency ramp tables overlap #271

valeriof7 opened this issue Dec 16, 2024 · 0 comments

Comments

@valeriof7
Copy link

In PR #268, the following code block in include/tudat/astro/ground_stations/transmittingFrequencies.h and relative unit test has been commented out, but needs to be addressed:
"""
// If there are discontinuities
if ( startTimes_.at( i ) != endTimes_.at( i - 1 ) )
{
// If the start and end times are inconsistent throw error
if ( endTimes_.at( i - 1 ) > startTimes_.at( i ) )
{
throw std::runtime_error(
"Error when creating piecewise linear frequency interpolator: inconsistency between ramp end "
"time (" + std::to_string( double( endTimes_.at( i - 1 ) ) ) + ") and start time of the following ramp (" +
std::to_string( double( startTimes_.at( i ) ) ) + "); the end is smaller than the start time." );
}
// If there are gaps in the data save that information
else
{
invalidTimeBlocksStartTimes_.push_back( endTimes_.at( i - 1 ) );
invalidTimeBlocksEndTimes_.push_back( startTimes_.at( i ) );
}
"""

In particular, we need to properly implement the logic to deal with overlaps in the DSN transmit frequency ramp table. Possible solutions suggested by @DominicDirkx:

  • check if the tables are only slightly different (same frequencies possibly referenced to a different date)
  • select one of the tables and reset the time range of the other one
  • give a warning
  • give an exception
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant