Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment may not be updated when checking termination condition #136

Open
DominicDirkx opened this issue Jan 11, 2023 · 0 comments
Open

Comments

@DominicDirkx
Copy link
Member

When checking for a termination condition:
https://github.com/tudat-team/tudat/blob/master/include/tudat/astro/propagators/integrateEquations.h#L620
the physical environment will not necesarilly be updated to the current time and state, unless dependent variables are saved
https://github.com/tudat-team/tudat/blob/master/include/tudat/astro/propagators/integrateEquations.h#L602
if not, the environment will be at the state/time of the last function evaluation (minor step), not that of the current major step.

This issue can be addressed by consolidating the various operations that need to be performed on the creation of a major step into a single block that:

  • Updates the environment (if needed, with more fine-grained checks than are currently the case)
  • Computes the dependent variables
  • Checks the termination condition
  • Checks for and handles events (to be implemented)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: tudat
Development

No branches or pull requests

1 participant