Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write developer guidelines #13

Open
FilippoOggionni opened this issue Apr 5, 2022 · 9 comments
Open

Write developer guidelines #13

FilippoOggionni opened this issue Apr 5, 2022 · 9 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@FilippoOggionni
Copy link
Member

Write developer guidelines (as from this Slack post).

@FilippoOggionni FilippoOggionni added the documentation Improvements or additions to documentation label Apr 5, 2022
@FilippoOggionni FilippoOggionni self-assigned this Apr 5, 2022
@FilippoOggionni
Copy link
Member Author

A draft is available here.

Waiting for review from @DominicDirkx @gaffarelj @geoffreygarrett 😃

@gaffarelj
Copy link
Member

Great guide, I made some minor changes with 4a2fd66.

I would just say that all of this is very clear to me, but things may be more obscure to new developers. Especially, it may be good to add a small paragraph at the beginning of the guide to link to the DevOps resources section. This way, if things seem obscure, help does not seem too far. (Especially how tudat is organised in many repositories. You mention multiple times that there is tudat in C++, tudatpy in Python, tudat-multidocs, etc... but I don't know if devs that read this page should already be used to all of these or not.)

@FilippoOggionni
Copy link
Member Author

Good point! I think including a page somewhere about the organization of the tudat ecosystem (all the repos, what they are meant for, etc...) is a great idea and very much needed. I already have some ideas about that and some material written in a README, so I will take care of that. This page should be the first things developers read / come across in the developer docs, in my opinion.

Question: do you think developers should read first the DevOps resources sections or first the checklist? In other words, do you think a developer needs to know the content from the resources before being able to understand the checklist?

@gaffarelj
Copy link
Member

Question: do you think developers should read first the DevOps resources sections or first the checklist? In other words, do you think a developer needs to know the content from the resources before being able to understand the checklist?

I prefer having the checklist first, and resources second. But mentioning that the resources section exists at the beginning of the page could be useful.

@FilippoOggionni
Copy link
Member Author

But mentioning that the resources section exists at the beginning of the page could be useful.

Sounds good, I will do that!

Regarding the overview page, do you have already an idea of where it could be placed in the toctree?

@FilippoOggionni
Copy link
Member Author

I added the following note, do you think it is enough?

Screen Shot 2022-04-07 at 23 43 01

@FilippoOggionni
Copy link
Member Author

Changes have been implemented through 0ce93aa (and published on the website at latest).

@gaffarelj
Copy link
Member

I added the following note, do you think it is enough?

Yes, I think nothing more would be needed, perfect for me :)

Regarding the overview page, do you have already an idea of where it could be placed in the toctree?

I would expect to find it at the top of the Software Development section (before the Build System and Developer Environment sections). Actually, I believe the Developer Environment section already covers most of what the overview page would describe. But I think the overview should go less into details, and give a more general... well... overview.

As a small note, I would also switch the sections in the following order: Software Development, Software Documentation, Dev Ops.

@DominicDirkx
Copy link
Member

Hi all, sorry to be late to the party :) I have made a couple of very small modifications. Below a few suggestions/requests:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants