Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor validation of instruction groups and sequence generation. #87

Open
4 of 5 tasks
marenz2569 opened this issue Nov 5, 2024 · 0 comments
Open
4 of 5 tasks
Labels
backlog technical debt Backlog of things that should be improved in the code-base

Comments

@marenz2569
Copy link
Member

marenz2569 commented Nov 5, 2024

Currently we check if a supplied instruction is valid in each compilePayload function.

DoD

  • Create a class for the sequence generation functionality.
  • Do checks as soon as possible. E.g. instruction group proportion is not equal to zero.
  • Check against the selected payload it the settings are allowed. This will also allow us to terminate earlier.
    • maybe wrapping a payload settings in a validated payload settings after we validate it to a specific payload (e.g. SSE2 or FMA)?
    • only validated payload settings may be provided into other interfaces.
    • Done with Refactor Function Selection #98
@marenz2569 marenz2569 added the backlog technical debt Backlog of things that should be improved in the code-base label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog technical debt Backlog of things that should be improved in the code-base
Projects
None yet
Development

No branches or pull requests

1 participant