Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve how to find available port for server #38

Closed
wants to merge 2 commits into from
Closed

Improve how to find available port for server #38

wants to merge 2 commits into from

Conversation

prokosna
Copy link
Contributor

@prokosna prokosna commented May 3, 2022

Web Server 起動時の listening ポートの特定方法を改善しました。
以前の実装で潜在的な問題と思われる

  • servicePort を fix してから当該ポートが使われてしまうケース
  • emptyPort() 内のテンポラリ server の完全な close の前に listen してしまうケース
  • ipv6 で listen してしまうケース

等を回避していると思います。

Ubuntu, Chrome OS (Debian) でも動作を確認しました。
Fix #32

@AoiMoe AoiMoe mentioned this pull request Sep 30, 2022
Closed
ttrace
ttrace approved these changes Oct 11, 2022
View reviewed changes
Copy link
Owner

@ttrace ttrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRありがとうございます。
b445d61fでようやくマージできました。

@ttrace
Copy link
Owner

ttrace commented Oct 11, 2022

b445d61　に手動マージ。

@ttrace ttrace closed this Oct 11, 2022
@ttrace ttrace mentioned this pull request Oct 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttrace ttrace ttrace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

（Linux-Debian ）縦書プレビュー時にポートがすでに使用されている
2 participants
@prokosna @ttrace