Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Menu Items > Status #51

Closed
ttgapers opened this issue Jul 1, 2020 · 7 comments
Closed

Additional Menu Items > Status #51

ttgapers opened this issue Jul 1, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@ttgapers
Copy link
Owner

ttgapers commented Jul 1, 2020

@Adamm00 @jackyaz @maghuro @jkychn
Not sure how how difficult it would be to get the following added to perhaps an Option 4 sub-menu:

4a: Upload Stats: tc -s qdisc show dev eth0
4b: Download Stats: tc -s qdisc show dev ifb9eth0
4c: Show traffic control settings: tc qdisc show

Thoughts?

@Adamm00
Copy link
Collaborator

Adamm00 commented Jul 1, 2020

d6eee17

@ttgapers
Copy link
Owner Author

ttgapers commented Jul 1, 2020

@Adamm00 - two comments:

  1. Would be good to go back to Option 3 menu than all the way out
  2. Is this one a bit more difficult than the other 2? Show traffic control settings: tc qdisc show

@Adamm00
Copy link
Collaborator

Adamm00 commented Jul 1, 2020

Would be good to go back to Option 3 menu than all the way out

Not sure what you mean by this

Is this one a bit more difficult than the other 2? Show traffic control settings: tc qdisc show

We show the important parts of this under the general option.

@Adamm00
Copy link
Collaborator

Adamm00 commented Jul 1, 2020

Added in #52

@Adamm00 Adamm00 closed this as completed Jul 1, 2020
@ttgapers
Copy link
Owner Author

ttgapers commented Jul 1, 2020

Would be good to go back to Option 3 menu than all the way out

Not sure what you mean by this

Is this one a bit more difficult than the other 2? Show traffic control settings: tc qdisc show

We show the important parts of this under the general option.

First item ugandy mentions here as well: https://www.snbforums.com/threads/release-cakeqos-merlin.64800/page-40#post-599088

Steps from Main Menu:
Select 3 (Cake Status)
Then pick any Status option
Hit any key to continue -- takes you back to the Main Menu, and not the Status Menu (preferred)

Hope that helps.

@Adamm00
Copy link
Collaborator

Adamm00 commented Jul 1, 2020

That's unfortunately not how the menu system works, it would require significantly messier code (every menu/submenu would need to be a function) and add unnecessary complexity for minimal benefit.

While it may be exciting to constantly tinker with cake because its a shiny new toy, it is designed to be a set and forget solution. Interaction with the script at all should be almost non-existent post configuration in a regular use-case outside debugging.

@ttgapers
Copy link
Owner Author

ttgapers commented Jul 1, 2020

I agree...I've settled on the defaults as my "best" for everyone. besteffort docsis ack-filter

Just thought it would be easy sub-menu-ing if just checking status and queues/tins. Just and extra couple inputs to get back to the Sub-menu screen. If it's too much effort, then kindly park it :) I can live with the extra clicks!

I keep pushing the KISS mantra -- don't ever worry. It's what started me here. Flex and FreshJR has too many configs to get it to a stable/working state. This just works.

@ttgapers ttgapers added the enhancement New feature or request label Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants