From ec6b2f9ba9aa0fdc025b55ffe01b3066ce619e25 Mon Sep 17 00:00:00 2001 From: Timothy Sullivan Date: Mon, 19 Aug 2024 16:06:10 -0700 Subject: [PATCH] fix tests --- .../management/spaces_management_app.test.tsx | 2 +- .../public/management/view_space/footer.tsx | 33 +++++++++---------- 2 files changed, 17 insertions(+), 18 deletions(-) diff --git a/x-pack/plugins/spaces/public/management/spaces_management_app.test.tsx b/x-pack/plugins/spaces/public/management/spaces_management_app.test.tsx index 00c640333d1db..a285abf0119d6 100644 --- a/x-pack/plugins/spaces/public/management/spaces_management_app.test.tsx +++ b/x-pack/plugins/spaces/public/management/spaces_management_app.test.tsx @@ -173,7 +173,7 @@ describe('spacesManagementApp', () => { css="You have tried to stringify object returned from \`css\` function. It isn't supposed to be used directly (e.g. as value of the \`className\` prop), but rather handed to emotion so it can handle it (e.g. as value of \`css\` prop)." data-test-subj="kbnRedirectAppLink" > - Spaces View Page: {"capabilities":{"catalogue":{},"management":{},"navLinks":{}},"serverBasePath":"","http":{"basePath":{"basePath":"","serverBasePath":"","assetsHrefBase":""},"anonymousPaths":{},"externalUrl":{},"staticAssets":{}},"overlays":{"banners":{}},"notifications":{"toasts":{}},"spacesManager":{"onActiveSpaceChange$":{}},"spaceId":"some-space","history":{"action":"PUSH","length":1,"location":{"pathname":"/edit/some-space","search":"","hash":""}}} + Spaces View Page: {"capabilities":{"catalogue":{},"management":{},"navLinks":{}},"serverBasePath":"","http":{"basePath":{"basePath":"","serverBasePath":"","assetsHrefBase":""},"anonymousPaths":{},"externalUrl":{},"staticAssets":{}},"overlays":{"banners":{}},"notifications":{"toasts":{}},"spacesManager":{"onActiveSpaceChange$":{}},"spaceId":"some-space","history":{"action":"PUSH","length":1,"location":{"pathname":"/edit/some-space","search":"","hash":""}},"allowFeatureVisibility":true,"allowSolutionVisibility":true} `); diff --git a/x-pack/plugins/spaces/public/management/view_space/footer.tsx b/x-pack/plugins/spaces/public/management/view_space/footer.tsx index fbfa71a86483a..bdfa6cf0b623f 100644 --- a/x-pack/plugins/spaces/public/management/view_space/footer.tsx +++ b/x-pack/plugins/spaces/public/management/view_space/footer.tsx @@ -47,24 +47,23 @@ export const ViewSpaceTabFooter: React.FC = ({ + + + Cancel + + + {isDirty && ( - <> - - - Cancel - - - - - Update space - - - + + + Update space + + )} )}