From 6fd29ff82de3bab40688aeb2443bc8a9fbaaf453 Mon Sep 17 00:00:00 2001 From: rexim Date: Sun, 20 Jun 2021 18:37:48 +0700 Subject: [PATCH 1/5] (#76) Try to fail build if the user forgot to run tsc --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d4bda48..9e774cc 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -11,3 +11,4 @@ jobs: node-version: '13' - run: npm install - run: ./node_modules/.bin/tsc + - run: git diff --exit-code From ff806c083dc8878221cf47fac5788408399df536 Mon Sep 17 00:00:00 2001 From: rexim Date: Sun, 20 Jun 2021 18:38:06 +0700 Subject: [PATCH 2/5] (#76) Document the building step --- README.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/README.md b/README.md index 939b463..afd72c7 100644 --- a/README.md +++ b/README.md @@ -17,6 +17,13 @@ $ python3 -m http.server 6969 $ iexplore.exe http://localhost:6969/ ``` +## Building JavaScript files + +```console +$ npm install +$ ./node_modules/.bin/tsc +``` + # Filter Development **WARNING! Knowledge of [WebGL](https://developer.mozilla.org/en-US/docs/Web/API/WebGL_API) or [OpenGL](https://www.opengl.org/) is required to read this section!** From 8fcd0a827f90965c0e415643d997f5519dfa3858 Mon Sep 17 00:00:00 2001 From: rexim Date: Sun, 20 Jun 2021 18:38:15 +0700 Subject: [PATCH 3/5] (#76) add useless code --- ts/eval.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ts/eval.ts b/ts/eval.ts index 5ccc100..895426d 100644 --- a/ts/eval.ts +++ b/ts/eval.ts @@ -12,6 +12,9 @@ interface BinaryOpDef { prec: BinaryPrec } +function f() { +} + const BINARY_OPS: {[op in BinaryOp]: BinaryOpDef} = { '+': { func: (lhs, rhs) => lhs + rhs, From d214d813be4e244021df17e34dcd05890c5df44a Mon Sep 17 00:00:00 2001 From: rexim Date: Sun, 20 Jun 2021 18:43:44 +0700 Subject: [PATCH 4/5] Revert "(#76) add useless code" This reverts commit 8fcd0a827f90965c0e415643d997f5519dfa3858. --- ts/eval.ts | 3 --- 1 file changed, 3 deletions(-) diff --git a/ts/eval.ts b/ts/eval.ts index 895426d..5ccc100 100644 --- a/ts/eval.ts +++ b/ts/eval.ts @@ -12,9 +12,6 @@ interface BinaryOpDef { prec: BinaryPrec } -function f() { -} - const BINARY_OPS: {[op in BinaryOp]: BinaryOpDef} = { '+': { func: (lhs, rhs) => lhs + rhs, From e6aa6db862433cc91870c2cf28e7ca538f2ffe55 Mon Sep 17 00:00:00 2001 From: rexim Date: Sun, 20 Jun 2021 18:45:36 +0700 Subject: [PATCH 5/5] (#76) Add Development Workflow section to README --- README.md | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index afd72c7..4ece392 100644 --- a/README.md +++ b/README.md @@ -17,12 +17,13 @@ $ python3 -m http.server 6969 $ iexplore.exe http://localhost:6969/ ``` -## Building JavaScript files +## Development Workflow -```console -$ npm install -$ ./node_modules/.bin/tsc -``` +1. `$ npm install` +2. `$ ./node_modules/.bin/tsc -w` +3. `` + +Make sure that you commit the generated `js/*` files along with your changes. This is important for the project to retain that "Just deploy the repo" attitude. # Filter Development