Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es6 import modules support #33

Open
roblav96 opened this issue May 24, 2016 · 3 comments
Open

es6 import modules support #33

roblav96 opened this issue May 24, 2016 · 3 comments
Labels

Comments

@roblav96
Copy link

roblav96 commented May 24, 2016

Recently switching my projects to es6 with babel, I'd like to do something like this with lockr:

import {
    get,
    set,
} from 'lockr'

but when I call get this error throws:

TypeError: Cannot read property '_getPrefixedKey' of undefined
var query_key = this._getPrefixedKey(key, options)

Not a big deal; importing the entire library is not a problem because it's small and minimal.

Thank you =]

@tsironis tsironis added the bug label May 26, 2016
@tsironis
Copy link
Owner

tsironis commented May 26, 2016

@roblav96 good catch. I've never used Lockr in ES6 env, but I know why it doesn't work. It will require a major refactor on how the lib works under the hood.

@roblav96
Copy link
Author

No worries at all man! Still loving lockr to death haha

@tsironis
Copy link
Owner

I would appreciate a pull request, if you want to give it a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants