Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(language): implement more bigint ops #63

Merged
merged 9 commits into from
Nov 4, 2023
Merged

Conversation

sno2
Copy link
Contributor

@sno2 sno2 commented Nov 1, 2023

No description provided.

Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice stuff, thank you <3

nova_vm/src/ecmascript/types/language/bigint.rs Outdated Show resolved Hide resolved
nova_vm/src/ecmascript/types/language/bigint.rs Outdated Show resolved Hide resolved
nova_vm/src/ecmascript/types/language/bigint.rs Outdated Show resolved Hide resolved
nova_vm/src/ecmascript/types/language/bigint.rs Outdated Show resolved Hide resolved
nova_vm/src/ecmascript/types/language/bigint.rs Outdated Show resolved Hide resolved
nova_vm/src/engine/small_integer.rs Outdated Show resolved Hide resolved
nova_vm/src/engine/small_integer.rs Show resolved Hide resolved
@aapoalas aapoalas merged commit 37de064 into main Nov 4, 2023
1 check passed
@aapoalas aapoalas deleted the feat/more-bigint-ops branch November 4, 2023 12:17
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ig another pr

BigInt::BigInt(x_index) => {
let x_data = agent.heap.get(x_index);
agent.heap.create(BigIntHeapData {
data: -&x_data.data,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
data: -&x_data.data,
data: !&x_data.data,

Bit late, my apologies

@andreubotella andreubotella mentioned this pull request Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants