Skip to content

Commit

Permalink
feat: Implement some simple intrinsics
Browse files Browse the repository at this point in the history
  • Loading branch information
@eliassjogreen
eliassjogreen committed Nov 14, 2024
1 parent 7887a8c commit 857ab9a
Show file tree
Hide file tree
Showing 4 changed files with 164 additions and 48 deletions.
51 changes: 47 additions & 4 deletions ...vm/src/ecmascript/builtins/indexed_collections/typed_array_objects/abstract_operations.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ use crate::{
get_value_from_buffer, is_detached_buffer, is_fixed_length_array_buffer,
set_value_in_buffer, Ordering, ViewedArrayBufferByteLength,
},
indexed_collections::typed_array_objects::typed_array_intrinsic_object::require_internal_slot_typed_array,
ordinary::get_prototype_from_constructor,
typed_array::{
data::{TypedArrayArrayLength, TypedArrayHeapData},
Expand All @@ -19,8 +20,8 @@ use crate::{
},
execution::{agent::ExceptionType, Agent, JsResult, ProtoIntrinsics},
types::{
Function, InternalMethods, InternalSlots, IntoFunction, Object, PropertyKey, Value,
Viewable,
Function, InternalMethods, InternalSlots, IntoFunction, Object, PropertyKey, U8Clamped,
Value, Viewable,
},
},
engine::context::GcScope,
Expand All @@ -29,8 +30,8 @@ use crate::{
};

pub(crate) struct TypedArrayWithBufferWitnessRecords {
object: TypedArray,
cached_buffer_byte_length: Option<usize>,
pub object: TypedArray,
pub cached_buffer_byte_length: Option<usize>,
}

/// ### [10.4.5.9 MakeTypedArrayWithBufferWitnessRecord ( obj, order )](https://tc39.es/ecma262/#sec-maketypedarraywithbufferwitnessrecord)
Expand Down Expand Up @@ -232,6 +233,48 @@ pub(crate) fn is_typed_array_out_of_bounds<T: Viewable>(
false
}

/// ### [23.2.4.4 ValidateTypedArray ( O, order )](https://tc39.es/ecma262/#sec-validatetypedarray)
///
/// The abstract operation ValidateTypedArray takes arguments O (an ECMAScript
/// language value) and order (seq-cst or unordered) and returns either a normal
/// completion containing a TypedArray With Buffer Witness Record or a throw
/// completion.
pub(crate) fn validate_typed_array(
agent: &mut Agent,
o: Value,
order: Ordering,
) -> JsResult<TypedArrayWithBufferWitnessRecords> {
// 1. Perform ? RequireInternalSlot(O, [[TypedArrayName]]).
let o = require_internal_slot_typed_array(agent, o)?;
// 2. Assert: O has a [[ViewedArrayBuffer]] internal slot.
// 3. Let taRecord be MakeTypedArrayWithBufferWitnessRecord(O, order).
let ta_record = make_typed_array_with_buffer_witness_record(agent, o, order);
// 4. If IsTypedArrayOutOfBounds(taRecord) is true, throw a TypeError exception.
if match o {
TypedArray::Int8Array(_) => is_typed_array_out_of_bounds::<i8>(agent, &ta_record),
TypedArray::Uint8Array(_) => is_typed_array_out_of_bounds::<u8>(agent, &ta_record),
TypedArray::Uint8ClampedArray(_) => {
is_typed_array_out_of_bounds::<U8Clamped>(agent, &ta_record)
}
TypedArray::Int16Array(_) => is_typed_array_out_of_bounds::<i16>(agent, &ta_record),
TypedArray::Uint16Array(_) => is_typed_array_out_of_bounds::<u16>(agent, &ta_record),
TypedArray::Int32Array(_) => is_typed_array_out_of_bounds::<i32>(agent, &ta_record),
TypedArray::Uint32Array(_) => is_typed_array_out_of_bounds::<u32>(agent, &ta_record),
TypedArray::BigInt64Array(_) => is_typed_array_out_of_bounds::<i64>(agent, &ta_record),
TypedArray::BigUint64Array(_) => is_typed_array_out_of_bounds::<u64>(agent, &ta_record),
TypedArray::Float32Array(_) => is_typed_array_out_of_bounds::<f32>(agent, &ta_record),
TypedArray::Float64Array(_) => is_typed_array_out_of_bounds::<f64>(agent, &ta_record),
} {
return Err(agent.throw_exception_with_static_message(
ExceptionType::TypeError,
"TypedArray out of bounds",
));
}

// 5. Return taRecord.
Ok(ta_record)
}

/// ### [23.2.5.1.1 AllocateTypedArray ( constructorName, newTarget, defaultProto \[ , length \] )](https://tc39.es/ecma262/#sec-allocatetypedarray)
///
/// The abstract operation AllocateTypedArray takes arguments constructorName
Expand Down
127 changes: 113 additions & 14 deletions ...mascript/builtins/indexed_collections/typed_array_objects/typed_array_intrinsic_object.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ use crate::ecmascript::abstract_operations::testing_and_comparison::is_array;
use crate::ecmascript::builders::builtin_function_builder::BuiltinFunctionBuilder;
use crate::ecmascript::builders::ordinary_object_builder::OrdinaryObjectBuilder;
use crate::ecmascript::builtins::array_buffer::Ordering;
use crate::ecmascript::builtins::indexed_collections::array_objects::array_iterator_objects::array_iterator::ArrayIterator;
use crate::ecmascript::builtins::indexed_collections::array_objects::array_iterator_objects::array_iterator::CollectionIteratorKind;
use crate::ecmascript::builtins::typed_array::TypedArray;
use crate::ecmascript::builtins::ArgumentsList;
use crate::ecmascript::builtins::Behaviour;
Expand Down Expand Up @@ -33,6 +35,8 @@ use crate::heap::WellKnownSymbolIndexes;
use super::abstract_operations::is_typed_array_out_of_bounds;
use super::abstract_operations::make_typed_array_with_buffer_witness_record;
use super::abstract_operations::typed_array_byte_length;
use super::abstract_operations::typed_array_length;
use super::abstract_operations::validate_typed_array;

pub struct TypedArrayIntrinsicObject;

Expand Down Expand Up @@ -487,14 +491,24 @@ impl TypedArrayPrototype {
todo!()
}

/// ### [23.2.3.7 %TypedArray%.prototype.entries ( )](https://tc39.es/ecma262/#sec-%typedarray%.prototype.entries)
fn entries(
_agent: &mut Agent,
agent: &mut Agent,
_gc: GcScope<'_, '_>,

_this_value: Value,
this_value: Value,
_: ArgumentsList,
) -> JsResult<Value> {
todo!()
// 1. Let O be the this value.
// 2. Perform ? ValidateTypedArray(O, seq-cst).
let o = validate_typed_array(agent, this_value, Ordering::SeqCst)?;
// 3. Return CreateArrayIterator(O, key+value).
Ok(ArrayIterator::from_object(
agent,
o.object.into_object(),
CollectionIteratorKind::KeyAndValue,
)
.into_value())
}

fn every(
Expand Down Expand Up @@ -607,14 +621,22 @@ impl TypedArrayPrototype {
todo!()
}

/// ### [23.2.3.19 %TypedArray%.prototype.keys ( )](https://tc39.es/ecma262/#sec-%typedarray%.prototype.keys)
fn keys(
_agent: &mut Agent,
agent: &mut Agent,
_gc: GcScope<'_, '_>,

_this_value: Value,
this_value: Value,
_: ArgumentsList,
) -> JsResult<Value> {
todo!()
// 1. Let O be the this value.
// 2. Perform ? ValidateTypedArray(O, seq-cst).
let o = validate_typed_array(agent, this_value, Ordering::SeqCst)?;
// 3. Return CreateArrayIterator(O, key).
Ok(
ArrayIterator::from_object(agent, o.object.into_object(), CollectionIteratorKind::Key)
.into_value(),
)
}

fn last_index_of(
Expand All @@ -627,14 +649,54 @@ impl TypedArrayPrototype {
todo!()
}

/// ### [23.2.3.21 get %TypedArray%.prototype.length](https://tc39.es/ecma262/#sec-get-%typedarray%.prototype.length)
fn get_length(
_agent: &mut Agent,
agent: &mut Agent,
_gc: GcScope<'_, '_>,

_this_value: Value,
this_value: Value,
_: ArgumentsList,
) -> JsResult<Value> {
todo!()
// 1. Let O be the this value.
// 2. Perform ? RequireInternalSlot(O, [[TypedArrayName]]).
// 3. Assert: O has [[ViewedArrayBuffer]] and [[ArrayLength]] internal slots.
let o = require_internal_slot_typed_array(agent, this_value)?;
// 4. Let taRecord be MakeTypedArrayWithBufferWitnessRecord(O, seq-cst).
let ta_record = make_typed_array_with_buffer_witness_record(agent, o, Ordering::SeqCst);
// 5. If IsTypedArrayOutOfBounds(taRecord) is true, return +0𝔽.
if match o {
TypedArray::Int8Array(_) => is_typed_array_out_of_bounds::<i8>(agent, &ta_record),
TypedArray::Uint8Array(_) => is_typed_array_out_of_bounds::<u8>(agent, &ta_record),
TypedArray::Uint8ClampedArray(_) => {
is_typed_array_out_of_bounds::<U8Clamped>(agent, &ta_record)
}
TypedArray::Int16Array(_) => is_typed_array_out_of_bounds::<i16>(agent, &ta_record),
TypedArray::Uint16Array(_) => is_typed_array_out_of_bounds::<u16>(agent, &ta_record),
TypedArray::Int32Array(_) => is_typed_array_out_of_bounds::<i32>(agent, &ta_record),
TypedArray::Uint32Array(_) => is_typed_array_out_of_bounds::<u32>(agent, &ta_record),
TypedArray::BigInt64Array(_) => is_typed_array_out_of_bounds::<i64>(agent, &ta_record),
TypedArray::BigUint64Array(_) => is_typed_array_out_of_bounds::<u64>(agent, &ta_record),
TypedArray::Float32Array(_) => is_typed_array_out_of_bounds::<f32>(agent, &ta_record),
TypedArray::Float64Array(_) => is_typed_array_out_of_bounds::<f64>(agent, &ta_record),
} {
return Ok(Value::pos_zero());
}
// 6. Let length be TypedArrayLength(taRecord).
let length = match o {
TypedArray::Int8Array(_) => typed_array_length::<i8>(agent, &ta_record),
TypedArray::Uint8Array(_) => typed_array_length::<u8>(agent, &ta_record),
TypedArray::Uint8ClampedArray(_) => typed_array_length::<U8Clamped>(agent, &ta_record),
TypedArray::Int16Array(_) => typed_array_length::<i16>(agent, &ta_record),
TypedArray::Uint16Array(_) => typed_array_length::<u16>(agent, &ta_record),
TypedArray::Int32Array(_) => typed_array_length::<i32>(agent, &ta_record),
TypedArray::Uint32Array(_) => typed_array_length::<u32>(agent, &ta_record),
TypedArray::BigInt64Array(_) => typed_array_length::<i64>(agent, &ta_record),
TypedArray::BigUint64Array(_) => typed_array_length::<u64>(agent, &ta_record),
TypedArray::Float32Array(_) => typed_array_length::<f32>(agent, &ta_record),
TypedArray::Float64Array(_) => typed_array_length::<f64>(agent, &ta_record),
} as i64;
// 7. Return 𝔽(length).
Ok(Value::try_from(length).unwrap())
}

fn map(
Expand Down Expand Up @@ -767,14 +829,26 @@ impl TypedArrayPrototype {
todo!();
}

/// ### [23.2.3.35 %TypedArray%.prototype.values ( )](https://tc39.es/ecma262/#sec-get-%typedarray%.prototype-%symbol.tostringtag%)
fn values(
_agent: &mut Agent,
agent: &mut Agent,
_gc: GcScope<'_, '_>,

_this_value: Value,
this_value: Value,
_: ArgumentsList,
) -> JsResult<Value> {
todo!();
// 1. Let O be the this value.
// 2. Perform ? ValidateTypedArray(O, seq-cst).
let o = validate_typed_array(agent, this_value, Ordering::SeqCst)?;
// 3. Return CreateArrayIterator(O, value).
Ok(
ArrayIterator::from_object(
agent,
o.object.into_object(),
CollectionIteratorKind::Value,
)
.into_value(),
)
}

fn with(
Expand All @@ -787,14 +861,39 @@ impl TypedArrayPrototype {
todo!();
}

/// ### [23.2.3.38 get %TypedArray%.prototype \[ %Symbol.toStringTag% \]](https://tc39.es/ecma262/#sec-get-%typedarray%.prototype-%symbol.tostringtag%)
fn get_to_string_tag(
_agent: &mut Agent,
_gc: GcScope<'_, '_>,

_this_value: Value,
this_value: Value,
_: ArgumentsList,
) -> JsResult<Value> {
todo!();
// 1. Let O be the this value.
if let Ok(o) = TypedArray::try_from(this_value) {
// 4. Let name be O.[[TypedArrayName]].
// 5. Assert: name is a String.
// 6. Return name.
match o {
TypedArray::Int8Array(_) => Ok(BUILTIN_STRING_MEMORY.Int8Array.into()),
TypedArray::Uint8Array(_) => Ok(BUILTIN_STRING_MEMORY.Uint8Array.into()),
TypedArray::Uint8ClampedArray(_) => {
Ok(BUILTIN_STRING_MEMORY.Uint8ClampedArray.into())
}
TypedArray::Int16Array(_) => Ok(BUILTIN_STRING_MEMORY.Int16Array.into()),
TypedArray::Uint16Array(_) => Ok(BUILTIN_STRING_MEMORY.Uint16Array.into()),
TypedArray::Int32Array(_) => Ok(BUILTIN_STRING_MEMORY.Int32Array.into()),
TypedArray::Uint32Array(_) => Ok(BUILTIN_STRING_MEMORY.Uint32Array.into()),
TypedArray::BigInt64Array(_) => Ok(BUILTIN_STRING_MEMORY.BigInt64Array.into()),
TypedArray::BigUint64Array(_) => Ok(BUILTIN_STRING_MEMORY.BigUint64Array.into()),
TypedArray::Float32Array(_) => Ok(BUILTIN_STRING_MEMORY.Float32Array.into()),
TypedArray::Float64Array(_) => Ok(BUILTIN_STRING_MEMORY.Float64Array.into()),
}
} else {
// 2. If O is not an Object, return undefined.
// 3. If O does not have a [[TypedArrayName]] internal slot, return undefined.
Ok(Value::Undefined)
}
}

pub(crate) fn create_intrinsic(agent: &mut Agent, realm: RealmIdentifier) {
Expand Down
Loading

0 comments on commit 857ab9a

Please sign in to comment.