Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add report to source_document meta #913

Conversation

JimFuller-RedHat
Copy link
Collaborator

@JimFuller-RedHat JimFuller-RedHat commented Oct 10, 2024

Generate sbomsleuth report when ingesting sbom which fixes #896

We will need to discuss where this report data is exposed .. possibly on api/v1/sbom endpoints ?

Also collocate the test for each tool in the same file.
This should make it easier to find and work on each tool individually
@ctron
Copy link
Contributor

ctron commented Oct 10, 2024

I think the idea is good. But what I don't like is that we now have two "reports". One from sbomsleuth, the other existing report. And that we seem to have two different ways dealing with them.

I'd prefer if we could merge the sbomsleuth report and the warnings in a single thing. Which we collect in the importer run report, report back on the API, and store in the source document table.

@JimFuller-RedHat
Copy link
Collaborator Author

sure one thing better then two ;)

The importer run report does not currently work on any sboms uploaded via rest api (or maybe I missed it?) ... I was hoping to get some direction on unifying on that axis as well.

Also - do we want to 'bake in' heuristics on reports in trustify or push that to some calling client to decide (and maintain) ?

Sounds like we need to discuss further.

@ctron
Copy link
Contributor

ctron commented Oct 10, 2024

image

@ctron
Copy link
Contributor

ctron commented Oct 10, 2024

🤣 Let's have a chat.

@JimFuller-RedHat JimFuller-RedHat deleted the add-quality-report branch October 14, 2024 18:43
@JimFuller-RedHat JimFuller-RedHat restored the add-quality-report branch October 14, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SBOM quality reporting
3 participants