Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slot Options #140

Open
My1 opened this issue Nov 27, 2020 · 1 comment
Open

Slot Options #140

My1 opened this issue Nov 27, 2020 · 1 comment

Comments

@My1
Copy link

My1 commented Nov 27, 2020

a few things:

  1. Return OTP is in there twice
    This doesnt seem intentional, especially considering they are even in the same radio-group

image

I think it would make sense to remove the upper one to keep the 2FA options nicely grouped.

  1. no option to disable 2FA in the slot, like on most other where you have none as an option

  2. maybe it could be tidied up a little bit, e.g. instead of radios everywhere, places where you just have one option and none, like Tab before OTP or Return after OTP replaced with a single checkbox and places where more options exist like Tab/Return after Username with a dropdown that has a text label before it like "interaction after Username"

  3. what's that kinda out of place arrow in the top left supposed to be about?

@My1 My1 changed the title 2FA Options Slot Options Nov 27, 2020
@onlykey
Copy link
Collaborator

onlykey commented Jun 9, 2021

Return OTP is in there twice

Its the same radio button but listed under TOTP because we had support requests for there being no return after OTP because when it was not right next to the TOTP option it wasn't obvious. You are right we could probably reorder this better.

no option to disable 2FA in the slot, like on most other where you have none as an option

We plan to add this in future release.

what's that kinda out of place arrow in the top left supposed to be about?

This is normally positioned right above the check boxes. We added this because we had a lot of support requests where someone was submitting without checking the box and wondering why it was not saving what they submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants