Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fixed data handling logic in verification flow for web #590

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

birtony
Copy link
Contributor

@birtony birtony commented Sep 6, 2023

Signed-off-by: Anton Biriukov [email protected]

@birtony birtony self-assigned this Sep 6, 2023
@cla-bot cla-bot bot added the cla-signed label Sep 6, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (6caf401) 89.98% compared to head (0e94686) 89.98%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #590   +/-   ##
=======================================
  Coverage   89.98%   89.98%           
=======================================
  Files          98       98           
  Lines        3896     3896           
=======================================
  Hits         3506     3506           
  Misses        258      258           
  Partials      132      132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@talwinder50 talwinder50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi did we tested the change in the app ? So we removed the stored credential while presenting credential now ?

@birtony
Copy link
Contributor Author

birtony commented Sep 6, 2023

Hi did we tested the change in the app ? So we removed the stored credential while presenting credential now ?

Hey @talwinder50 ! Yes, I tested on web and on iOS as well. The parameter you're talking about was passed down but never actually used in the web logic, so I dropped it. cc @DRK3

@birtony birtony force-pushed the fix-presentation-preview branch from 0e94686 to 927e0d6 Compare September 7, 2023 14:14
@rolsonquadras rolsonquadras merged commit dc9d264 into trustbloc:main Sep 7, 2023
8 checks passed
@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@birtony birtony deleted the fix-presentation-preview branch September 7, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants