Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): Change masking character to a bullet #579

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

DRK3
Copy link
Collaborator

@DRK3 DRK3 commented Aug 30, 2023

Also made some improvements to the Resolve Display docs.

@cla-bot cla-bot bot added the cla-signed label Aug 30, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1d1d531) 89.95% compared to head (e6945a8) 89.95%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #579   +/-   ##
=======================================
  Coverage   89.95%   89.95%           
=======================================
  Files          98       98           
  Lines        3882     3882           
=======================================
  Hits         3492     3492           
  Misses        258      258           
  Partials      132      132           
Files Changed Coverage Δ
pkg/credentialschema/credentialdisplay.go 98.66% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Also made some improvements to the Resolve Display docs.

Signed-off-by: Derek Trider <[email protected]>
@DRK3 DRK3 force-pushed the ChangeMaskingCharToBullet branch from e6945a8 to 820bd0e Compare August 31, 2023 14:12
@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.0% 3.0% Duplication

@rolsonquadras rolsonquadras merged commit ba49639 into trustbloc:main Aug 31, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants