feat(sdk): Make credentials optional for GetSubmissionRequirements #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talwinder50
approved these changes
Aug 30, 2023
DRK3
force-pushed
the
MakeCredentialsOptionalInGetSubmissionRequirements
branch
2 times, most recently
from
a3cf991 to
ac650af
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #577 +/- ##
==========================================
- Coverage 90.01% 89.95% -0.07%
==========================================
Files 98 98
Lines 3907 3882 -25
==========================================
- Hits 3517 3492 -25
Misses 258 258
Partials 132 132
☔ View full report in Codecov by Sentry. |
GetSubmissionRequirements can now be called with no credentials passed in. This supports the use case where the caller has no credentials that match but wants to check the type constraint and/or schemas specified by the input descriptors. Also removed an unused CredentialReader option and some unused error codes. Signed-off-by: Derek Trider <[email protected]>
DRK3
force-pushed
the
MakeCredentialsOptionalInGetSubmissionRequirements
branch
from
ac650af to
d36f638
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
rolsonquadras
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetSubmissionRequirements can now be called with no credentials passed in. This supports the use case where the caller has no credentials that match but wants to check the type constraint and/or schemas specified by the input descriptors.
Also removed an unused CredentialReader option and some unused error codes.