feat(app): Implement issuance preview screen ios #533
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #533 +/- ##
==========================================
+ Coverage 89.69% 89.80% +0.11%
==========================================
Files 97 98 +1
Lines 3745 3747 +2
==========================================
+ Hits 3359 3365 +6
+ Misses 257 255 -2
+ Partials 129 127 -2 ☔ View full report in Codecov by Sentry. |
| didType = didType ?? "ion"; | ||
| keyType = keyType ?? "ED25519"; | ||
|
|
||
| var didResolution = await WalletSDKPlugin.createDID(didType, keyType); |
There was a problem hiding this comment.
Please refactor WalletSDKPlugin.createDID so it returns some structure as we did for other methods. To get rid of that encode decode part all over the code.
There was a problem hiding this comment.
Created this issue #534
| @@ -211,6 +211,12 @@ class WalletSDK extends WalletPlatform { | |||
| return null; | |||
| } | |||
|
|
|||
| Future<List<IssuerMetaData>> getIssuerMetaData() async { | |||
There was a problem hiding this comment.
Please add getIssuerMetaData() stub to wallet_sdk_js.dart in otherwise it will break the web version build.
Signed-off-by: Talwinder kaur <[email protected]>
talwinder50
force-pushed
the
issuanceprev
branch
from
e6942a8
to
7d18f21
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
No description provided.