Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rsa support for jwk #17

Merged
merged 2 commits into from
Feb 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions doc/jose/jwk/jwksupport/jwk.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
"crypto/ecdsa"
"crypto/ed25519"
"crypto/elliptic"
"crypto/rsa"
"crypto/x509"
"crypto/x509/pkix"
"encoding/asn1"
Expand Down Expand Up @@ -62,7 +63,7 @@ func JWKFromKey(opaqueKey interface{}) (*jwk.JWK, error) {
// PubKeyBytesToKey creates an opaque key struct from the given public key bytes.
// It's e.g. *ecdsa.PublicKey, *ecdsa.PrivateKey, ed25519.VerificationMethod, *bbs12381g2pub.PrivateKey or
// *bbs12381g2pub.PublicKey.
func PubKeyBytesToKey(bytes []byte, keyType kms.KeyType) (interface{}, error) { // nolint:gocyclo
func PubKeyBytesToKey(bytes []byte, keyType kms.KeyType) (interface{}, error) { // nolint:gocyclo,funlen
switch keyType {
case kms.ED25519Type:
return ed25519.PublicKey(bytes), nil
Expand Down Expand Up @@ -99,6 +100,13 @@ func PubKeyBytesToKey(bytes []byte, keyType kms.KeyType) (interface{}, error) {
}

return ecKey, nil
case kms.RSARS256, kms.RSAPS256:
pubKeyRsa, err := x509.ParsePKIXPublicKey(bytes)
if err != nil {
return nil, errors.New("rsa: invalid public key")
}

return pubKeyRsa, nil
case kms.ECDSASecp256k1TypeDER:
return parseSecp256k1DER(bytes)
case kms.NISTP256ECDHKWType, kms.NISTP384ECDHKWType, kms.NISTP521ECDHKWType:
Expand Down Expand Up @@ -165,7 +173,8 @@ func PubKeyBytesToJWK(bytes []byte, keyType kms.KeyType) (*jwk.JWK, error) {
kms.ECDSASecp256k1TypeIEEEP1363, kms.ECDSASecp256k1TypeDER,
kms.ECDSAP256TypeIEEEP1363, kms.ECDSAP384TypeIEEEP1363, kms.ECDSAP521TypeIEEEP1363,
kms.ECDSAP256TypeDER, kms.ECDSAP384TypeDER, kms.ECDSAP521TypeDER,
kms.NISTP256ECDHKWType, kms.NISTP384ECDHKWType, kms.NISTP521ECDHKWType:
kms.NISTP256ECDHKWType, kms.NISTP384ECDHKWType, kms.NISTP521ECDHKWType,
kms.RSARS256, kms.RSAPS256:
key, err := PubKeyBytesToKey(bytes, keyType)
if err != nil {
return nil, err
Expand Down Expand Up @@ -246,6 +255,9 @@ func PublicKeyFromJWK(jwkKey *jwk.JWK) (*cryptoapi.PublicKey, error) {
pubKey.X = bbsKey
case ed25519.PublicKey:
pubKey.X = key
case *rsa.PublicKey:
pubKey.N = key.N.Bytes()
pubKey.E = big.NewInt(int64(key.E)).Bytes()
case ed25519.PrivateKey:
var ok bool

Expand Down
40 changes: 40 additions & 0 deletions doc/jose/jwk/jwksupport/jwk_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
"crypto/ed25519"
"crypto/elliptic"
"crypto/rand"
"crypto/rsa"
"crypto/sha256"
"crypto/x509"
"crypto/x509/pkix"
Expand Down Expand Up @@ -433,6 +434,21 @@ func TestPubKeyBytesToKey(t *testing.T) {
},
expectType: &ecdsa.PublicKey{},
},
{
keyTypes: []kms.KeyType{
kms.RSARS256,
kms.RSAPS256,
},
getKey: func(keyType kms.KeyType) ([]byte, error) {
key, err := rsa.GenerateKey(rand.Reader, 2048)
if err != nil {
return nil, err
}

return x509.MarshalPKIXPublicKey(&key.PublicKey)
},
expectType: &rsa.PublicKey{},
},
{
keyTypes: []kms.KeyType{
kms.ECDSASecp256k1TypeDER,
Expand Down Expand Up @@ -844,6 +860,30 @@ func TestPublicKeyFromJWK(t *testing.T) {
})
}

func TestRSAKeyFailParse(t *testing.T) {
resultJWK, err := PubKeyBytesToJWK([]byte{0x1}, kms.RSARS256)
require.ErrorContains(t, err, "rsa: invalid public key")
require.Nil(t, resultJWK)
}

func TestRSAKey(t *testing.T) {
key, err := rsa.GenerateKey(rand.Reader, 2048)
require.NoError(t, err)

pubBytes, err := x509.MarshalPKIXPublicKey(&key.PublicKey)
require.NoError(t, err)

resultJWK, err := PubKeyBytesToJWK(pubBytes, kms.RSARS256)
require.NoError(t, err)

pb, err := PublicKeyFromJWK(resultJWK)
require.NoError(t, err)
require.NotNil(t, pb)
require.NotNil(t, pb.N)
require.NotNil(t, pb.E)
require.Equal(t, "RSA", pb.Type)
}

type PublicKeyInfo struct {
Raw asn1.RawContent
Algorithm pkix.AlgorithmIdentifier
Expand Down
2 changes: 2 additions & 0 deletions spi/crypto/crypto.go
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,8 @@ type RecipientWrappedKey struct {
type PublicKey struct {
KID string `json:"kid,omitempty"`
X []byte `json:"x,omitempty"`
N []byte `json:"n,omitempty"`
E []byte `json:"e,omitempty"`
Y []byte `json:"y,omitempty"`
Curve string `json:"curve,omitempty"`
Type string `json:"type,omitempty"`
Expand Down
Loading