Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue Comments Have no Effect with App Permissions #115

Open
afrazkhan opened this issue Mar 20, 2024 · 0 comments
Open

Issue Comments Have no Effect with App Permissions #115

afrazkhan opened this issue Mar 20, 2024 · 0 comments

Comments

@afrazkhan
Copy link

Everything works great with github.TOKEN, but when using a Github App (to get the approval team expansion working), approval comments are never picked up from the created issue. Issues are created (and even closed when cancelling the job) just fine, but the pipelines never continue after an approval message.

It's likely a missing permissions, and the event permission Issue comment seems like an obvious necessity, but even adding that didn't help matters.
afrazkhan added a commit to guidion-digital/terrappy that referenced this issue Mar 21, 2024
@afrazkhan
Manual approval teams ...
e969f20 
... unfortunately, the teams lookup function for the manual approval job doesn't fully work, so until this bug is resolved, that addition has to be commented out:

trstringer/manual-approval#115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@afrazkhan