Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

fix: make promise deserialization less flaky #21

Merged
merged 11 commits into from
Oct 4, 2023
Merged

fix: make promise deserialization less flaky #21

merged 11 commits into from
Oct 4, 2023

Conversation

KATT
Copy link
Member

@KATT KATT commented Oct 3, 2023

  • loosen lint rules
  • make promise deserialization less flaky

		"no-inner-declarations": "off",@typescript-eslint/no-explicit-any
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/async/asyncTypes.ts 100.00% <100.00%> (ø)
src/async/deserializeAsync.ts 99.08% <100.00%> (+11.64%) ⬆️
src/sync/createTson.ts 100.00% <ø> (ø)
src/sync/deserialize.ts 100.00% <ø> (ø)
src/sync/serialize.ts 100.00% <ø> (ø)
src/types.ts 100.00% <ø> (ø)
src/internals/assert.ts 87.50% <87.50%> (ø)
src/internals/testUtils.ts 97.61% <96.42%> (-2.39%) ⬇️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@KATT KATT changed the title chore: disable @typescript-eslint/no-explicit-any for project chore: loosen some lint rules Oct 4, 2023
@KATT KATT marked this pull request as ready for review October 4, 2023 18:05
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@KATT KATT changed the title chore: loosen some lint rules fix: make promise deserialization less flaky Oct 4, 2023
@KATT KATT enabled auto-merge (squash) October 4, 2023 18:28
@KATT KATT disabled auto-merge October 4, 2023 18:29
@KATT KATT merged commit 4cadad0 into main Oct 4, 2023
11 checks passed
@KATT KATT deleted the no-explicit-any branch October 4, 2023 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants