From dadeef857cb23c12b730459f36b9a4328ca4c9e9 Mon Sep 17 00:00:00 2001 From: Benjamin Kaplan <58792807+bskaplan@users.noreply.github.com> Date: Thu, 15 Aug 2024 14:13:01 -0700 Subject: [PATCH] docs: fix inaccurate docs for Cloud Run environment variables (#11398) --- mmv1/products/cloudrunv2/Job.yaml | 4 ++-- mmv1/products/cloudrunv2/Service.yaml | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/mmv1/products/cloudrunv2/Job.yaml b/mmv1/products/cloudrunv2/Job.yaml index df5a01cfa09a..1a2c750107ca 100644 --- a/mmv1/products/cloudrunv2/Job.yaml +++ b/mmv1/products/cloudrunv2/Job.yaml @@ -322,7 +322,7 @@ properties: - !ruby/object:Api::Type::Array name: 'args' description: |- - Arguments to the entrypoint. The docker image's CMD is used if this is not provided. Variable references $(VAR_NAME) are expanded using the container's environment. If a variable cannot be resolved, the reference in the input string will be unchanged. The $(VAR_NAME) syntax can be escaped with a double $$, ie: $$(VAR_NAME). Escaped references will never be expanded, regardless of whether the variable exists or not. More info: https://kubernetes.io/docs/tasks/inject-data-application/define-command-argument-container/#running-a-command-in-a-shell + Arguments to the entrypoint. The docker image's CMD is used if this is not provided. Variable references are not supported in Cloud Run. item_type: Api::Type::String - !ruby/object:Api::Type::Array name: 'env' @@ -338,7 +338,7 @@ properties: - !ruby/object:Api::Type::String name: 'value' description: |- - Variable references $(VAR_NAME) are expanded using the previous defined environment variables in the container and any route environment variables. If a variable cannot be resolved, the reference in the input string will be unchanged. The $(VAR_NAME) syntax can be escaped with a double $$, ie: $$(VAR_NAME). Escaped references will never be expanded, regardless of whether the variable exists or not. Defaults to "", and the maximum length is 32768 bytes + Literal value of the environment variable. Defaults to "" and the maximum allowed length is 32768 characters. Variable references are not supported in Cloud Run. # exactly_one_of: # - template.0.template.0.containers.0.env.0.value # - template.0.template.0.containers.0.env.0.valueSource diff --git a/mmv1/products/cloudrunv2/Service.yaml b/mmv1/products/cloudrunv2/Service.yaml index 1117bb5840e5..c26f2b7d2f98 100644 --- a/mmv1/products/cloudrunv2/Service.yaml +++ b/mmv1/products/cloudrunv2/Service.yaml @@ -399,7 +399,7 @@ properties: - !ruby/object:Api::Type::Array name: 'args' description: |- - Arguments to the entrypoint. The docker image's CMD is used if this is not provided. Variable references $(VAR_NAME) are expanded using the container's environment. If a variable cannot be resolved, the reference in the input string will be unchanged. The $(VAR_NAME) syntax can be escaped with a double $$, ie: $$(VAR_NAME). Escaped references will never be expanded, regardless of whether the variable exists or not. More info: https://kubernetes.io/docs/tasks/inject-data-application/define-command-argument-container/#running-a-command-in-a-shell + Arguments to the entrypoint. The docker image's CMD is used if this is not provided. Variable references are not supported in Cloud Run. item_type: Api::Type::String - !ruby/object:Api::Type::Array name: 'env' @@ -411,11 +411,11 @@ properties: name: 'name' required: true description: |- - Name of the environment variable. Must be a C_IDENTIFIER, and mnay not exceed 32768 characters. + Name of the environment variable. Must be a C_IDENTIFIER, and may not exceed 32768 characters. - !ruby/object:Api::Type::String name: 'value' description: |- - Variable references $(VAR_NAME) are expanded using the previous defined environment variables in the container and any route environment variables. If a variable cannot be resolved, the reference in the input string will be unchanged. The $(VAR_NAME) syntax can be escaped with a double $$, ie: $$(VAR_NAME). Escaped references will never be expanded, regardless of whether the variable exists or not. Defaults to "", and the maximum length is 32768 bytes + Literal value of the environment variable. Defaults to "" and the maximum allowed length is 32768 characters. Variable references are not supported in Cloud Run. # exactly_one_of: # - template.0.containers.0.env.0.value # - template.0.containers.0.env.0.valueSource