Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement copy_neighborhood_search to allow empty "template" neighborhood search #32

Merged
merged 12 commits into from
Jun 24, 2024

Conversation

efaulhaber
Copy link
Member

Based on #30.

Closes #27.

@efaulhaber efaulhaber added the breaking changes This change will break the public API and requires a new major release label Jun 21, 2024
@efaulhaber efaulhaber changed the base branch from main to dev June 21, 2024 11:41
@efaulhaber efaulhaber closed this Jun 21, 2024
@efaulhaber efaulhaber reopened this Jun 21, 2024
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (dev@021f57f). Learn more about missing BASE report.

Files Patch % Lines
src/neighborhood_search.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev      #32   +/-   ##
======================================
  Coverage       ?   90.19%           
======================================
  Files          ?       11           
  Lines          ?      255           
  Branches       ?        0           
======================================
  Hits           ?      230           
  Misses         ?       25           
  Partials       ?        0           
Flag Coverage Δ
unit 90.19% <85.71%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efaulhaber efaulhaber marked this pull request as ready for review June 21, 2024 13:59
src/neighborhood_search.jl Outdated Show resolved Hide resolved
src/nhs_neighbor_lists.jl Show resolved Hide resolved
@efaulhaber efaulhaber requested a review from LasNikas June 24, 2024 08:08
@efaulhaber efaulhaber merged commit 5d52dfd into dev Jun 24, 2024
10 checks passed
@efaulhaber efaulhaber deleted the ef/copy-nhs branch June 24, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes This change will break the public API and requires a new major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure out how to pass neighborhood search to a TrixiParticles.jl simulation
2 participants