feat: Auto unload model if vLLM health check failed #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [WIP] vLLM check_health() is async * [WIP] Fix model name query * [WIP] Health check may only be enabled when instance count is 1
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rmccorm4
reviewed
Nov 20, 2024
rmccorm4
reviewed
Nov 20, 2024
rmccorm4
reviewed
Nov 20, 2024
rmccorm4
reviewed
Nov 21, 2024
This reverts commit b986aea.
…d into jacky-vllm-health
kthui
changed the title
GuanLuo
reviewed
Nov 26, 2024
GuanLuo
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Call the vLLM Health Check API upon receiving each request, and auto unload the model via BLS if the health check failed.
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
N/A
Where should the reviewer start?
Start with the documentation, and then move on to the code, and finally the test case.
Test plan:
New tests are added to verify the health check, auto model unload, and enabling/disabling of the check.
Caveats:
N/A
Background
N/A
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
N/A