From 97456d081b1d6ed0445d6e0a52c85142e8549918 Mon Sep 17 00:00:00 2001 From: Anant Sharma Date: Mon, 21 Oct 2024 11:11:06 -0700 Subject: [PATCH 1/4] skip warning errors --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 3368050..682b3fd 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -166,7 +166,7 @@ target_compile_features(triton-tensorrt-backend PRIVATE cxx_std_${TRITON_MIN_CXX target_compile_options( triton-tensorrt-backend PRIVATE $<$,$,$>: - -Wall -Wextra -Wno-unused-parameter -Wno-type-limits -Werror -Wno-deprecated-declarations> + -Wall -Wextra -Wno-unused-parameter -Wno-type-limits -Wno-deprecated-declarations> $<$:/Wall /D_WIN32_WINNT=0x0A00 /EHsc /Zc:preprocessor> ) From eefd782c9f23e9d3397fea7a1fbce328e474797c Mon Sep 17 00:00:00 2001 From: Anant Sharma Date: Tue, 29 Oct 2024 11:40:05 -0700 Subject: [PATCH 2/4] Revert "skip warning errors" This reverts commit 97456d081b1d6ed0445d6e0a52c85142e8549918. --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 682b3fd..3368050 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -166,7 +166,7 @@ target_compile_features(triton-tensorrt-backend PRIVATE cxx_std_${TRITON_MIN_CXX target_compile_options( triton-tensorrt-backend PRIVATE $<$,$,$>: - -Wall -Wextra -Wno-unused-parameter -Wno-type-limits -Wno-deprecated-declarations> + -Wall -Wextra -Wno-unused-parameter -Wno-type-limits -Werror -Wno-deprecated-declarations> $<$:/Wall /D_WIN32_WINNT=0x0A00 /EHsc /Zc:preprocessor> ) From 2d6367a7746907f7e90f60a152be530a20e8cfcd Mon Sep 17 00:00:00 2001 From: Anant Sharma Date: Tue, 29 Oct 2024 12:52:50 -0700 Subject: [PATCH 3/4] disable maybe-uninitialize warning errors --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 3368050..cf6eb7a 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -166,7 +166,7 @@ target_compile_features(triton-tensorrt-backend PRIVATE cxx_std_${TRITON_MIN_CXX target_compile_options( triton-tensorrt-backend PRIVATE $<$,$,$>: - -Wall -Wextra -Wno-unused-parameter -Wno-type-limits -Werror -Wno-deprecated-declarations> + -Wall -Wextra -Wno-unused-parameter -Wno-type-limits -Wno-error=maybe-uninitialized -Werror -Wno-deprecated-declarations> $<$:/Wall /D_WIN32_WINNT=0x0A00 /EHsc /Zc:preprocessor> ) From 27f14b7bff6701552ef923b0036ba1da9316040e Mon Sep 17 00:00:00 2001 From: Anant Sharma Date: Tue, 29 Oct 2024 13:45:04 -0700 Subject: [PATCH 4/4] remove werror --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index cf6eb7a..682b3fd 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -166,7 +166,7 @@ target_compile_features(triton-tensorrt-backend PRIVATE cxx_std_${TRITON_MIN_CXX target_compile_options( triton-tensorrt-backend PRIVATE $<$,$,$>: - -Wall -Wextra -Wno-unused-parameter -Wno-type-limits -Wno-error=maybe-uninitialized -Werror -Wno-deprecated-declarations> + -Wall -Wextra -Wno-unused-parameter -Wno-type-limits -Wno-deprecated-declarations> $<$:/Wall /D_WIN32_WINNT=0x0A00 /EHsc /Zc:preprocessor> )