Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for float type parameter in inference requests #6382

Closed
wemoveon2 opened this issue Oct 4, 2023 · 4 comments
Closed

Support for float type parameter in inference requests #6382

wemoveon2 opened this issue Oct 4, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@wemoveon2
Copy link

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Currently, when we need to pass a float we'd have to pass it as a string or rescale it into an integer and then scale it back into a float in the model files.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Would like for InferParameter to support double_param as a custom parameter
https://github.com/triton-inference-server/common/blob/468eb216b01b375b83590b1e206d1c8cf4160b38/protobuf/grpc_service.proto#L470-L476

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Currently converting to a string and then converting it back before it's used, which isn't ideal.

Additional context
Add any other context or screenshots about the feature request here.

@tanmayv25 tanmayv25 added the enhancement New feature or request label Oct 11, 2023
@tanmayv25
Copy link
Contributor

@wemoveon2 Great catch! We will support this!

@wemoveon2
Copy link
Author

Hey, any updates? is this feature planned for a release?

@fpetrini15
Copy link
Contributor

Hello @wemoveon2, unfortunately we had to prioritize other urgent items over the last few releases. This feature is not currently planned for a release, but I hope to have an update for you soon! When I do, I'll link you to the corresponding PR.

@fpetrini15
Copy link
Contributor

Hello @wemoveon2, I have merged the PRs relating to this request. Double type parameters will be supported in the 23.02 release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants