Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model Analyzer support for s3 repositories #790

Closed
Talavig opened this issue Nov 23, 2023 · 4 comments
Closed

Model Analyzer support for s3 repositories #790

Talavig opened this issue Nov 23, 2023 · 4 comments

Comments

@Talavig
Copy link

Talavig commented Nov 23, 2023

We are using tritonserver over k8s, and we are trying to use model analyzer to auto-config our models. As it currently stands and for security reasons, we are using an s3 external storage as our model repository, and when running our tritonserver pods we are loading our models with their config.pbtxt files from there.
Because of this, we are forced to use model analyzer in remote mode for analyzing our models (our research notebooks also sit on the same kubernetes cluster).
We would like model analyzer to overwrite the config.pbtxt file in our s3 storage, but as far as we know this is not currently supported. Are there any plans to include such a feature in the near future?
Thanks in advance:)

@tgerdesnv
Copy link
Collaborator

Hi @Talavig, yes we will be looking into this and other features around remote/s3/cloud profiling.

Can you clarify what your ask is? Just the ability to write results directly to s3? Is this a blocker? Or just inconvenient because you have to take the remote results and manually copy them back into s3?

@Talavig
Copy link
Author

Talavig commented Dec 4, 2023

I would like to have the ability to put an s3 path as the output path, and upload the new config.pbtxt automatically to our remote model repository, because I want to introduce automatic model configuration as part of my model deployment pipeline.
From my understanding, as it currently stands, the only way to do this now is to parse the ckpt file, reformat it as an config.pbtxt file, and upload the result outside of model analyzer.

@tgerdesnv
Copy link
Collaborator

From my understanding, as it currently stands, the only way to do this now is to parse the ckpt file, reformat it as an config.pbtxt file, and upload the result outside of model analyzer.

Yikes! That is messy, and I'm sorry you had to do that. The good news is that r23.11 was just released, and it includes a commit that sounds like it would be useful to you. MA will now write the config.pbtxt file when running in remote mode:
#784

Hopefully that would make your life a bit easier -- you would just need to copy the file from local to S3. However, I hear that you still want to be able to have that output go directly into an S3 directory instead of local?

@tgerdesnv
Copy link
Collaborator

Closing due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants