Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 import don't work with additional sorts #169

Open
siamkreative opened this issue Oct 21, 2018 · 5 comments · May be fixed by #208
Open

ES6 import don't work with additional sorts #169

siamkreative opened this issue Oct 21, 2018 · 5 comments · May be fixed by #208

Comments

@siamkreative
Copy link

While this works:

import Tablesort from 'tablesort'

I don't know how to import the additional sorts (example: number, date). Could you please document this?

@dpmango
Copy link

dpmango commented Apr 17, 2019

+1 to this issue.

I think src/sorts/ should be marked as exportable modules

@xsonic
Copy link

xsonic commented Jun 12, 2019

+1

@siamkreative
Copy link
Author

I believe this library is no longer maintained :(

@tristen
Copy link
Owner

tristen commented Sep 6, 2019

👋 Pull requests happily accepted!

@contradictioned
Copy link

Importing the sort files directly does not work, as inside of them Tablesort is not defined.
This here is working (at least for webpack):
https://github.com/contradictioned/tablesort/commit/c00ff8271828d06e3dbca4af27f7d993a25c438a

Problem is, that this import probably does not work with a plain-old-javascript setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants