Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve README #12

Open
nineinchnick opened this issue Apr 18, 2022 · 4 comments
Open

Improve README #12

nineinchnick opened this issue Apr 18, 2022 · 4 comments

Comments

@nineinchnick
Copy link
Member

The README should be focused on users, not developers. For devs, we might add a DEVELOPER.md file.

@nineinchnick
Copy link
Member Author

There should be examples how to incorporate time as a filter ($__timeFilter) in the query.

@mrveera
Copy link
Contributor

mrveera commented Apr 22, 2022

We should have examples for all macros

@nineinchnick
Copy link
Member Author

I just tested macros and they work, this is great.

Example query:

select $__timeGroup(created_at,'1w') as date, to_milliseconds(avg(merged_at - created_at)) / 3600000 as avg_ttm_hours
from hive.v2.unique_pulls
where $__timeFilter(created_at)
group by 1
order by 1

We might be able to reuse most of this as docs: https://grafana.com/docs/grafana/latest/datasources/postgres/

@nineinchnick
Copy link
Member Author

Also improve the getting started section. It should not assume users have built the plugin locally, instead use the GF_INSTALL_PLUGINS environment variable, like:

docker run -d -p 3000:3000 --name=grafana \
  -e "GF_INSTALL_PLUGINS=trino-datasource" \
  grafana/grafana-oss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants