-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address OPARequest #148
Comments
You'd only short circuit on |
@Randgalt We would want to shortcut it mostly on |
I suggest throwing an exception or making a new response as you offered: |
I prefer creating a new response type, I like the no-throw contract we have for the security classes, its easier to track where decisions are made. I was thinking of In |
I'm assuming the |
As @mosiac1 , we can do this by using sealed interfaces where the types are OpaRequest and SecurityResponse. I can raise a draft PR for this |
Closed by #150 |
Currently, in OpaS3SecurityFacadeProvider, the function, does two operations:
The return type of the function is
SecurityResponse
.The issue we are currently facing is that while building the OPA request, based on some rules/ conditions we want to shortcut the OPA decision to either
SecurityResponse - SUCCESS or FAILURE
without sending a request to OPA server.We could have the
opaS3SecurityMapper.toRequest
returning a wrapper containing(OpaRequest | SecurityResponse)
, and based onSecurityResponse
we shortcut the decision or proceed with further steps. WDYT ?How should we handle this ?
@Randgalt , @vagaerg , @mosiac1
The text was updated successfully, but these errors were encountered: