Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bind IdentityType at top-level #138

Closed
Randgalt opened this issue Aug 7, 2024 · 2 comments
Closed

Bind IdentityType at top-level #138

Randgalt opened this issue Aug 7, 2024 · 2 comments

Comments

@Randgalt
Copy link
Member

Randgalt commented Aug 7, 2024 

          Since we are mapping abstract types, it is not possible to have the jsonCodecBinder registered in the module. However, once the abstract type has been mapped at a higher level, we could register the jsonCodecBinder. I'll address that in a separate PR since this change affects the FileBasedCredentialsProvider as well.

Originally posted by @pranavr12 in #136 (comment)
@Randgalt Randgalt mentioned this issue Aug 7, 2024
Merged
@vagaerg
Copy link
Member

vagaerg commented Aug 15, 2024

I believe this was addressed by #145 , could we close this?

@pranavr12
Copy link
Contributor

pranavr12 commented Aug 19, 2024 •
edited
Loading

Fixed through #141. Closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Randgalt @vagaerg @pranavr12