Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Upload Dropzone - Not able to reset error state #851

Open
msankaran0712 opened this issue Nov 10, 2022 · 4 comments · May be fixed by #2904
Open

File Upload Dropzone - Not able to reset error state #851

msankaran0712 opened this issue Nov 10, 2022 · 4 comments · May be fixed by #2904
Assignees
Labels
3 3 story points bug Something is wrong and needs to be addressed modus Bugs and features reported by Modus Team modus-file-dropzone priority:medium Prioritization for this item is medium

Comments

@msankaran0712
Copy link
Contributor

Once an error state is achieved looks like there is no way to attempt the upload again, trying to drop a valid file is not clearing the error message.

Steps to reproduce the behavior:

  1. Go to File upload drop zone
  2. Upload multiple files and appears an error message
  3. Attempt upload again with a valid file, the error message doesn't go away, and the file used in the upload is opening in the browser.

Expected behavior
The error message should be cleared when the upload is valid.

chrome_ZwIPPkwfE2

@msankaran0712 msankaran0712 added the bug Something is wrong and needs to be addressed label Nov 10, 2022
@enowak1031 enowak1031 changed the title File Upload Drop Zone - Not able to reset error state File Upload Drodzone - Not able to reset error state Feb 24, 2023
@msankaran0712 msankaran0712 added the 3 3 story points label Mar 3, 2023
@coliff coliff changed the title File Upload Drodzone - Not able to reset error state File Upload Dropzone - Not able to reset error state Mar 7, 2023
@msankaran0712 msankaran0712 added the modus Bugs and features reported by Modus Team label Apr 14, 2023
@msankaran0712 msankaran0712 added the priority:medium Prioritization for this item is medium label Nov 9, 2023
@cjwinsor
Copy link
Contributor

@enowak1031 @egunther39 Can we refine the requirements on the interactions? Do we allow for user to clear error message? I assume it should allow drop regardless.

@egunther39
Copy link

@cjwinsor - Add a button that allows the user to "Reset" the error state back to default. Text string should explain what the error is eg. "Multiple files are not allowed. Please try again"

Image

@prashanth-offcl
Copy link
Collaborator

The behavior of the reset button for each error state needs to be identified.

  • Multiple files are not allowed. - Remove all files? or Keep the first file and remove all other files?
  • You can only upload files - Keep the first files and remove the rest of them?
  • File name exceeds length limit: - Remove the files that fails this validation?
  • File exceeds size limit - Remove the files that fails this validation?

Note: Need to understand how the component is used by the consumer. If the consumer displays something like file list panel where they have the file name and delete icon, then it is possible they also highlight the file that failed the validation allowing the user to take appropriate action. In this particular case, when the user clicks the delete icon to remove the multiple files the consumer will call the removeFile method and the error state will be reset when there is only one file remaining.

@prashanth-offcl
Copy link
Collaborator

The expected behavior is to reset to the initial state of the component on clicking the reset button.

@ElishaSamPeterPrabhu ElishaSamPeterPrabhu linked a pull request Oct 4, 2024 that will close this issue
13 tasks
@ElishaSamPeterPrabhu ElishaSamPeterPrabhu linked a pull request Oct 4, 2024 that will close this issue
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 3 story points bug Something is wrong and needs to be addressed modus Bugs and features reported by Modus Team modus-file-dropzone priority:medium Prioritization for this item is medium
Projects
Status: PR Review
Development

Successfully merging a pull request may close this issue.

5 participants