Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: ensure compatibility for all derivation paths between old/new app #53

Closed
emturner opened this issue Oct 10, 2023 · 1 comment · Fixed by #106
Closed

Test: ensure compatibility for all derivation paths between old/new app #53

emturner opened this issue Oct 10, 2023 · 1 comment · Fixed by #106
Assignees
@ajinkyaraj-23
Labels
app::wallet issues relating to the wallet app good first issue Good for newcomers tests test - related isues
Milestone
Wallet: v3.0.3 - ...

Comments

@emturner
Copy link
Collaborator

The following derivation paths must match on both apps (same addresses derived):

  "ledger://***/ed25519/0h/0h"
  "ledger://***/secp256k1/0h/0h"
  "ledger://***/P-256/0h/0h"
  "ledger://***/bip25519/0h/0h"
@emturner emturner added the good first issue Good for newcomers label Oct 10, 2023
@emturner
Copy link
Collaborator Author

emturner commented Oct 10, 2023 •
edited
Loading

bip25519 needs testing - need to add test_provide_tz1_bip25519.sh for the nano devices.

@emturner emturner mentioned this issue Oct 10, 2023
Open
@emturner emturner added tests test - related isues app::wallet issues relating to the wallet app labels Oct 24, 2023
@ajinkyaraj-23 ajinkyaraj-23 linked a pull request Oct 31, 2023 that will close this issue
tests: add bip25519 derivation in integration tests #106
Merged
@emturner emturner mentioned this issue Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajinkyaraj-23 ajinkyaraj-23

Labels
app::wallet issues relating to the wallet app good first issue Good for newcomers tests test - related isues
Projects
None yet
Milestone
Wallet: v3.0.3 - security audit
Development

Successfully merging a pull request may close this issue.

tests: add bip25519 derivation in integration tests trilitech/ledger-app-tezos-wallet
2 participants
@emturner @ajinkyaraj-23