Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generated tests for summary pages and warning pages #270

Closed
ajinkyaraj-23 opened this issue Aug 23, 2024 · 3 comments · Fixed by #276
Closed

Fix generated tests for summary pages and warning pages #270

ajinkyaraj-23 opened this issue Aug 23, 2024 · 3 comments · Fixed by #276
Assignees
@spalmer25
Labels
app::wallet issues relating to the wallet app
Milestone
fix-scrolling

Comments

@ajinkyaraj-23
Copy link
Collaborator

Warning and summary pages being introduced to solve unlimited scrolling.
Generated tests fail because of summary page addition.
@ajinkyaraj-23 ajinkyaraj-23 added the app::wallet issues relating to the wallet app label Aug 23, 2024
@ajinkyaraj-23 ajinkyaraj-23 added this to the fix-scrolling milestone Aug 23, 2024
@ajinkyaraj-23 ajinkyaraj-23 mentioned this issue Aug 23, 2024
Closed
@ajinkyaraj-23
Copy link
Collaborator Author

Can we disable generated tests until we fix our flow for larger transactions?

@spalmer25
Copy link
Collaborator

Can we disable generated tests until we fix our flow for larger transactions?

Yes, we'll just have to ping this issue when we disable them to keep tracking the decisions we've made.

@spalmer25 spalmer25 mentioned this issue Sep 11, 2024
Merged
5 tasks
@spalmer25 spalmer25 linked a pull request Sep 11, 2024 that will close this issue
Limit the number of screens displayed for signing review for Nano #276
Merged
5 tasks
@ajinkyaraj-23
Copy link
Collaborator Author

Completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spalmer25 spalmer25

Labels
app::wallet issues relating to the wallet app
Projects
None yet
Milestone
fix-scrolling
Development

Successfully merging a pull request may close this issue.

Limit the number of screens displayed for signing review for Nano trilitech/ledger-app-tezos-wallet
2 participants
@spalmer25 @ajinkyaraj-23