-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TriBITS: CuSolver TPL still uses raw find_library call #13624
Comments
@bartlettroscoe, I encountered this while rebuilding our code (without rebuilding Trilinos) after the CUDA installation on our system was moved. The build failed due to a single hard-coded path in the Trilinos installation (in CUSOLVERConfig.cmake). Digging into the origin of that hard-coded path, I found that the cuSOLVER TPL was inconsistent with the other CUDA TPLs and traced it back to #11093. This seemed like an oversight in that PR. |
@terwin, if you are in position to give this a try, could you try updating cmake/TPLs/FindTPLCUSOLVER.cmake to replicate the changes made in those other modules? |
@bartlettroscoe, sure. I'll submit a PR later today. |
Thanks for doing the legwork on this @terwin and @bartlettroscoe ! |
Bug Report
@bartlettroscoe
Description
#11093 updated CUDA TPLs to use
find_package(CUDATookit)
rather than rawfind_
commands, but cmake/TPLs/FindTPLCUSOLVER.cmake was excluded.The text was updated successfully, but these errors were encountered: