Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TriBITS: CuSolver TPL still uses raw find_library call #13624

Closed
terwin opened this issue Nov 21, 2024 · 5 comments
Closed

TriBITS: CuSolver TPL still uses raw find_library call #13624

terwin opened this issue Nov 21, 2024 · 5 comments
Labels
type: bug The primary issue is a bug in Trilinos code or tests

Comments

@terwin
Copy link

terwin commented Nov 21, 2024

Bug Report

@bartlettroscoe

Description

#11093 updated CUDA TPLs to use find_package(CUDATookit) rather than raw find_ commands, but cmake/TPLs/FindTPLCUSOLVER.cmake was excluded.

@terwin terwin added the type: bug The primary issue is a bug in Trilinos code or tests label Nov 21, 2024
@bartlettroscoe
Copy link
Member

CC: @trilinos/framework, @sebrowne

@terwin, what is the underlying driver for this request? PR #11093 was in response to a specific issue with a customer code (see #10954).

@terwin
Copy link
Author

terwin commented Nov 21, 2024

@bartlettroscoe, I encountered this while rebuilding our code (without rebuilding Trilinos) after the CUDA installation on our system was moved. The build failed due to a single hard-coded path in the Trilinos installation (in CUSOLVERConfig.cmake). Digging into the origin of that hard-coded path, I found that the cuSOLVER TPL was inconsistent with the other CUDA TPLs and traced it back to #11093. This seemed like an oversight in that PR.

@bartlettroscoe
Copy link
Member

@terwin, if you are in position to give this a try, could you try updating cmake/TPLs/FindTPLCUSOLVER.cmake to replicate the changes made in those other modules?

@terwin
Copy link
Author

terwin commented Nov 22, 2024

@bartlettroscoe, sure. I'll submit a PR later today.

@sebrowne
Copy link
Contributor

Thanks for doing the legwork on this @terwin and @bartlettroscoe !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Development

No branches or pull requests

3 participants