Tacho : compile error with OpenMP (tol is used only by Team)

Signed-off-by: iyamazaki <[email protected]>
trilinos · Nov 14, 2024 · 7cd69d1 · 7cd69d1
1 parent 9990b44
commit 7cd69d1
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/packages/shylu/shylu_dd/frosch/test/Thyra_Xpetra_Laplace/main.cpp b/packages/shylu/shylu_dd/frosch/test/Thyra_Xpetra_Laplace/main.cpp
@@ -270,7 +270,6 @@ int main(int argc, char *argv[])
         } else {
             assert(false);
         }
-        writeMM("Laplace.mtx",KMonolithic);
 
         RCP<MultiVector<SC,LO,GO,NO> > xSolution = MultiVectorFactory<SC,LO,GO,NO>::Build(KMonolithic->getMap(),1);
         RCP<MultiVector<SC,LO,GO,NO> > xRightHandSide = MultiVectorFactory<SC,LO,GO,NO>::Build(KMonolithic->getMap(),1);

diff --git a/packages/shylu/shylu_node/tacho/src/impl/Tacho_LU_External.hpp b/packages/shylu/shylu_node/tacho/src/impl/Tacho_LU_External.hpp
@@ -61,6 +61,12 @@ template <> struct LU<Algo::External> {
     }
   }
 
+  template <typename MemberType, typename ViewTypeA, typename ViewTypeP>
+  KOKKOS_INLINE_FUNCTION static int invoke(MemberType &member, const double /*tol*/, const ViewTypeA &A, const ViewTypeP &P) {
+    // tol is not used, for now
+    return invoke(member, A, P);
+  }
+
   template <typename ViewTypeP> inline static int modify(const ordinal_type m, const ViewTypeP &P) {
 
     static constexpr bool runOnHost = run_tacho_on_host_v<typename ViewTypeP::execution_space>;

diff --git a/packages/shylu/shylu_node/tacho/src/impl/Tacho_LU_Serial.hpp b/packages/shylu/shylu_node/tacho/src/impl/Tacho_LU_Serial.hpp
@@ -61,6 +61,12 @@ template <> struct LU<Algo::Serial> {
     }
   }
 
+  template <typename MemberType, typename ViewTypeA, typename ViewTypeP>
+  inline static int invoke(MemberType &member, const double /*tol*/, const ViewTypeA &A, const ViewTypeP &P) {
+    // tol is not used, for now
+    return invoke(member, A, P);
+  }
+
   template <typename ViewTypeP> inline static int modify(const ordinal_type m, const ViewTypeP &P) {
 
     static constexpr bool runOnHost = run_tacho_on_host_v<typename ViewTypeP::execution_space>;