Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and improve wrappers #261

Merged
merged 40 commits into from
May 13, 2019
Merged

Commits on Jan 30, 2019

  1. Update to the latest SWIG

    aprokop committed Jan 30, 2019
    Configuration menu
    Copy the full SHA
    1ed796f View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2019

  1. Configuration menu
    Copy the full SHA
    9121096 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a582813 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    10bc19d View commit details
    Browse the repository at this point in the history
  4. Use F90 instead of f90 to enable C preprocessing

    The -cpp option interferes with CMake's Ninja generator.
    sethrj committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    a62ea87 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    309980f View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2019

  1. Simplify MultiVector wrapping

    sethrj committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    dce87c0 View commit details
    Browse the repository at this point in the history
  2. Clean warnings in unit tests

    sethrj committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    9cb7149 View commit details
    Browse the repository at this point in the history
  3. Replace local_ordinal_type with native Fortran int

    Also simplify literal types in the test code: this cleans up a number of
    warnings about conversions, including an unintentional conversion to
    single-precision reals (the literal 3.0 was used).
    
    Also commented out unused functions that were generating warnings.
    sethrj committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    d91a10d View commit details
    Browse the repository at this point in the history
  4. Improve Tpetra_Map interface

    sethrj committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    709ce03 View commit details
    Browse the repository at this point in the history
  5. Switch to typemaps in several classes

    This also removes a couple of functions that were returning arrayviews
    *by reference* (e.g. getGlobalRowView), so the wrappers that were in
    place actually did nothing.
    sethrj committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    0f09dd8 View commit details
    Browse the repository at this point in the history
  6. Improve typemap

    sethrj committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    eb2d742 View commit details
    Browse the repository at this point in the history
  7. Improve CRS typemaps

    sethrj committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    456e45e View commit details
    Browse the repository at this point in the history
  8. Replace "self" with "$self"

    sethrj committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    946af09 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    30a42a8 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b184d60 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    f1af717 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    e510045 View commit details
    Browse the repository at this point in the history
  13. Combine Import and Export headers

    Gets rid of the 'FIXME' since SWIG now knows about Import when
    instantiating Export.
    sethrj committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    2400ca0 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    e7b8129 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    993f275 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    8e994ab View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    4a05f37 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    86708c6 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    f5d7659 View commit details
    Browse the repository at this point in the history
  20. Fix assignment from null array

    Not clear why this was working in GCC. Whenever a SWIG execption function
    fails, it returns an empty/null value, which in the case of a SwigArray
    is `{null, 0}`. It's unspecified behavior to do `c_f_pointer` with
    zero-sized arrays. GCC was somehow working, but flang chose to convert
    this result to a null fortran pointer, which then is *assigned* to `iarr`
    before the throw condition is checked.
    
    The solution is to have the test return pointers rather than automatically
    allocating arrays.
    sethrj committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    fc13f68 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2019

  1. New test for broke TpetraCrsMatrix%getGlobalRowView

    Updated to latest SWIG. Currently fails to compile:
    
    ```
           call A%getGlobalRowView(gblrow, cgview(1:nnz), csview(1:nnz))
                                                                       1
    Error: Type mismatch in argument 'indices' at (1); passed INTEGER(8) to CLASS(swigtype_teuchos__arrayviewt_long_long_const_t)
    ```
    tjfulle authored and sethrj committed Feb 5, 2019
    Configuration menu
    Copy the full SHA
    ad811a0 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2019

  1. Configuration menu
    Copy the full SHA
    cb209b9 View commit details
    Browse the repository at this point in the history
  2. Add typemap for array RCP

    sethrj committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    2b04a71 View commit details
    Browse the repository at this point in the history
  3. Remove debug code

    sethrj committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    0fe1f28 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2019

  1. Add check for non-null pointer when taking ArrayView&

    Also clearing initial pointer assignments in the test.
    sethrj committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    4889bd1 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2019

  1. Configuration menu
    Copy the full SHA
    8ae8a94 View commit details
    Browse the repository at this point in the history
  2. Update for latest SWIG

    - Changes intent of mutable classes to intent(in) since we only modify
    the pointed-to-class, not the pointer
    - Fixes modification of "other" pointer during assignment, which would
    access possibly off-limits Fortran memory
    sethrj committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    11b2476 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2019

  1. Update to latest SWIG master

    - Updates memory management/assignment semantics
    - Fixes some latent type issues
    sethrj committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    f14c299 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2019

  1. Update to latest SWIG master

    sethrj committed May 9, 2019
    Configuration menu
    Copy the full SHA
    0e10afc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6f96b2c View commit details
    Browse the repository at this point in the history
  3. Silence warnings

    sethrj committed May 9, 2019
    Configuration menu
    Copy the full SHA
    6323e1f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7147ce9 View commit details
    Browse the repository at this point in the history
  5. Fix typos

    sethrj committed May 9, 2019
    Configuration menu
    Copy the full SHA
    5f137bc View commit details
    Browse the repository at this point in the history

Commits on May 10, 2019

  1. Configuration menu
    Copy the full SHA
    17ee435 View commit details
    Browse the repository at this point in the history