Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field 'file' in Page blueprint throws error since commit 7d497cc #149

Open
pamtbaau opened this issue Oct 30, 2021 · 5 comments
Open

Field 'file' in Page blueprint throws error since commit 7d497cc #149

pamtbaau opened this issue Oct 30, 2021 · 5 comments
Assignees
Labels
bug Something isn't working fixed Issue has already been fixed

Comments

@pamtbaau
Copy link

When using field file in a Page blueprint, AbstractController throws error at line 191: "Call to a member function getName() on null"

This happens since commit 7d497cc.

When reverting the commit, all goes well.

By the way, how about the warning in the docs about using field file in Page blueprints? Is that still valid?

@mahagr mahagr self-assigned this Nov 1, 2021
@mahagr mahagr added bug Something isn't working fixed Issue has already been fixed labels Nov 4, 2021
@mahagr
Copy link
Contributor

mahagr commented Nov 4, 2021

@pamtbaau Try my change.

@pamtbaau
Copy link
Author

pamtbaau commented Nov 4, 2021

@mahagr, All goes well now... Thanks!

By the way, is the warning in the docs NOT to use field file in a Page blueprint still valid?

The file field is intended to be used by configuration, theme, and plugins blueprints, NOT page blueprints. For pages, you should use the existing pagemedia field and then utilize the filepicker field to select the files.

@mahagr
Copy link
Contributor

mahagr commented Nov 4, 2021

Hmm, I think the file field should now work better than it used to.

@pamtbaau
Copy link
Author

pamtbaau commented Nov 4, 2021

Would you like me to create a PR to revert commits #80e85a7 and #29d2d99 on the file field?

@mahagr
Copy link
Contributor

mahagr commented Nov 4, 2021

I think the file field works as long as you use the new pages admin, but if you have it disabled, you'd run into those issues again. So yeah, maybe, but only if you're using the latest stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed Issue has already been fixed
Projects
None yet
Development

No branches or pull requests

2 participants