Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsForKubernetesHost #189

Merged
merged 3 commits into from
Jan 8, 2024
Merged

dnsForKubernetesHost #189

merged 3 commits into from
Jan 8, 2024

Conversation

pegtrifork
Copy link
Contributor

No description provided.

@pegtrifork pegtrifork requested a review from a team as a code owner January 8, 2024 14:34
AndersBennedsgaard
AndersBennedsgaard suggested changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@AndersBennedsgaard AndersBennedsgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a minor change and then LGTM

charts/flink-job/ci/full-values.yaml Outdated Show resolved Hide resolved
@pegtrifork pegtrifork merged commit a3eb2f8 into main Jan 8, 2024
5 checks passed
@pegtrifork pegtrifork deleted the dnsForKubernetesHost branch January 8, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersBennedsgaard AndersBennedsgaard AndersBennedsgaard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pegtrifork @AndersBennedsgaard